From: Sven Schnelle <svens@linux•ibm.com>
To: "Dmitry V. Levin" <ldv@strace•io>
Cc: Oleg Nesterov <oleg@redhat•com>,
Eugene Syromyatnikov <evgsyr@gmail•com>,
Mike Frysinger <vapier@gentoo•org>,
Renzo Davoli <renzo@cs•unibo.it>,
Davide Berardi <berardi.dav@gmail•com>,
strace-devel@lists•strace.io, Vineet Gupta <vgupta@kernel•org>,
Russell King <linux@armlinux•org.uk>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>, Brian Cain <bcain@quicinc•com>,
Huacai Chen <chenhuacai@kernel•org>,
WANG Xuerui <kernel@xen0n•name>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Michal Simek <monstr@monstr•eu>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
Dinh Nguyen <dinguyen@kernel•org>,
Jonas Bonn <jonas@southpole•se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti•fi>,
Stafford Horne <shorne@gmail•com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
Helge Deller <deller@gmx•de>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Christophe Leroy <christophe.leroy@csgroup•eu>,
Naveen N Rao <naveen@kernel•org>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Paul Walmsley <paul.walmsley@sifive•com>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Alexander Gordeev <agordeev@linux•ibm.com>,
Christian Borntraeger <borntraeger@linux•ibm.com>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Rich Felker <dalias@libc•org>,
John Paul Adrian Glaubitz <glaubitz@physik•fu-berlin.de>,
"David S. Miller" <davem@davemloft•net>,
Andreas Larsson <andreas@gaisler•com>,
Richard Weinberger <richard@nod•at>,
Anton Ivanov <anton.ivanov@cambridgegreys•com>,
Johannes Berg <johannes@sipsolutions•net>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
x86@kernel•org, "H. Peter Anvin" <hpa@zytor•com>,
Chris Zankel <chris@zankel•net>,
Max Filippov <jcmvbkbc@gmail•com>, Arnd Bergmann <arnd@arndb•de>,
linux-snps-arc@lists•infradead.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-hexagon@vger•kernel.org, loongarch@lists•linux.dev,
linux-m68k@lists•linux-m68k.org, linux-mips@vger•kernel.org,
linux-openrisc@vger•kernel.org, linux-parisc@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-riscv@lists•infradead.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
sparclinux@vger•kernel.org, linux-um@lists•infradead.org,
linux-arch@vger•kernel.org
Subject: Re: [PATCH 3/6] syscall.h: introduce syscall_set_nr()
Date: Fri, 10 Jan 2025 08:37:46 +0100 [thread overview]
Message-ID: <yt9dzfjz6rw5.fsf@linux.ibm.com> (raw)
In-Reply-To: <20250107230438.GC30633@strace.io> (Dmitry V. Levin's message of "Wed, 8 Jan 2025 01:04:38 +0200")
"Dmitry V. Levin" <ldv@strace•io> writes:
> Similar to syscall_set_arguments() that complements
> syscall_get_arguments(), introduce syscall_set_nr()
> that complements syscall_get_nr().
>
> syscall_set_nr() is going to be needed along with
> syscall_set_arguments() on all HAVE_ARCH_TRACEHOOK
> architectures to implement PTRACE_SET_SYSCALL_INFO API.
>
> Signed-off-by: Dmitry V. Levin <ldv@strace•io>
> ---
> arch/arc/include/asm/syscall.h | 6 ++++++
> arch/arm/include/asm/syscall.h | 12 ++++++++++++
> arch/arm64/include/asm/syscall.h | 7 +++++++
> arch/hexagon/include/asm/syscall.h | 7 +++++++
> arch/loongarch/include/asm/syscall.h | 7 +++++++
> arch/m68k/include/asm/syscall.h | 7 +++++++
> arch/microblaze/include/asm/syscall.h | 7 +++++++
> arch/mips/include/asm/syscall.h | 7 +++++++
> arch/nios2/include/asm/syscall.h | 5 +++++
> arch/openrisc/include/asm/syscall.h | 6 ++++++
> arch/parisc/include/asm/syscall.h | 7 +++++++
> arch/powerpc/include/asm/syscall.h | 5 +++++
> arch/riscv/include/asm/syscall.h | 7 +++++++
> arch/s390/include/asm/syscall.h | 7 +++++++
> arch/sh/include/asm/syscall_32.h | 7 +++++++
> arch/sparc/include/asm/syscall.h | 7 +++++++
> arch/um/include/asm/syscall-generic.h | 5 +++++
> arch/x86/include/asm/syscall.h | 7 +++++++
> arch/xtensa/include/asm/syscall.h | 7 +++++++
> include/asm-generic/syscall.h | 14 ++++++++++++++
> 20 files changed, 144 insertions(+)
>
> diff --git a/arch/s390/include/asm/syscall.h b/arch/s390/include/asm/syscall.h
> index b3dd883699e7..1c0e349fd5c9 100644
> --- a/arch/s390/include/asm/syscall.h
> +++ b/arch/s390/include/asm/syscall.h
> @@ -24,6 +24,13 @@ static inline long syscall_get_nr(struct task_struct *task,
> (regs->int_code & 0xffff) : -1;
> }
>
> +static inline void syscall_set_nr(struct task_struct *task,
> + struct pt_regs *regs,
> + int nr)
> +{
I think there should be a
if (!test_pt_regs_flags(regs, PIF_SYSCALL))
return;
before the modification so a user can't accidentally change int_code
when ptrace stopped in a non-syscall path.
> + regs->int_code = (regs->int_code & ~0xffff) | (nr & 0xffff);
> +}
> +
> static inline void syscall_rollback(struct task_struct *task,
> struct pt_regs *regs)
> {
next prev parent reply other threads:[~2025-01-10 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 23:01 [PATCH 0/6] ptrace: introduce PTRACE_SET_SYSCALL_INFO API Dmitry V. Levin
2025-01-07 23:04 ` [PATCH 1/6] Revert "arch: remove unused function syscall_set_arguments()" Dmitry V. Levin
2025-01-07 23:04 ` [PATCH 3/6] syscall.h: introduce syscall_set_nr() Dmitry V. Levin
2025-01-10 7:37 ` Sven Schnelle [this message]
2025-01-11 1:16 ` Dmitry V. Levin
2025-01-10 3:15 ` [PATCH 0/6] ptrace: introduce PTRACE_SET_SYSCALL_INFO API H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dzfjz6rw5.fsf@linux.ibm.com \
--to=svens@linux$(echo .)ibm.com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=andreas@gaisler$(echo .)com \
--cc=anton.ivanov@cambridgegreys$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=arnd@arndb$(echo .)de \
--cc=bcain@quicinc$(echo .)com \
--cc=berardi.dav@gmail$(echo .)com \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=chris@zankel$(echo .)net \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=dalias@libc$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dinguyen@kernel$(echo .)org \
--cc=evgsyr@gmail$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=glaubitz@physik$(echo .)fu-berlin.de \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=jonas@southpole$(echo .)se \
--cc=kernel@xen0n$(echo .)name \
--cc=ldv@strace$(echo .)io \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-openrisc@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loongarch@lists$(echo .)linux.dev \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=oleg@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=renzo@cs$(echo .)unibo.it \
--cc=richard@nod$(echo .)at \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=strace-devel@lists$(echo .)strace.io \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vapier@gentoo$(echo .)org \
--cc=vgupta@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox