From: "Gao Feng" <gfree.wind@vip•163.com>
To: "'David Ahern'" <dsa@cumulusnetworks•com>, <davem@davemloft•net>,
<jarod@redhat•com>, <lucien.xin@gmail•com>,
<stephen@networkplumber•org>, <netdev@vger•kernel.org>
Subject: RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice
Date: Tue, 2 May 2017 18:51:24 +0800 [thread overview]
Message-ID: <000201d2c332$0c73c320$255b4960$@vip.163.com> (raw)
In-Reply-To: <92eab1fc-cd70-1561-1f94-665e77725750@cumulusnetworks.com>
> From: David Ahern [mailto:dsa@cumulusnetworks•com]
> Sent: Monday, May 1, 2017 11:08 PM
> On 4/28/17 9:51 PM, gfree.wind@foxmail•com wrote:
> > diff --git a/drivers/net/veth.c b/drivers/net/veth.c index
> > 8c39d6d..418376a 100644
> > --- a/drivers/net/veth.c
> > +++ b/drivers/net/veth.c
> > @@ -224,9 +224,21 @@ static int veth_dev_init(struct net_device *dev)
> > return 0;
> > }
> >
> > -static void veth_dev_free(struct net_device *dev)
> > +static void veth_destructor_free(struct net_device *dev)
>
> _destructor in the name is confusing since veth_dev_free is the
> dev->destructor. Perhaps that should be veth_free_stats.
Because I want to emphasize it should be invoked in the destructor.
What's your opinion ?
[...]
> Functionally, it looks good to me.
>
> Acked-by: David Ahern <dsa@cumulusnetworks•com>
Thanks David.
I have sent the v4 patches with a series according to David's advice.
BTW, because I send multiple patches too fast today, the email server blocks
my account.
So I have to reply you with a different email account. Sorry.
Regards
Feng
next prev parent reply other threads:[~2017-05-02 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 3:51 [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice gfree.wind
2017-05-01 15:08 ` David Ahern
2017-05-02 10:51 ` Gao Feng [this message]
2017-05-02 7:55 ` Xin Long
2017-05-02 11:03 ` Gao Feng
2017-05-02 16:59 ` Xin Long
2017-05-03 2:07 ` Gao Feng
2017-05-03 5:37 ` Xin Long
2017-05-03 6:37 ` Gao Feng
2017-05-03 11:25 ` Xin Long
2017-05-03 13:17 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201d2c332$0c73c320$255b4960$@vip.163.com' \
--to=gfree.wind@vip$(echo .)163.com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=jarod@redhat$(echo .)com \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox