From: "Masayuki Ohtake" <masa-korg@dsn•okisemi.com>
To: "Wolfgang Grandegger" <wg@grandegger•com>
Cc: "Wang, Qi" <qi.wang@intel•com>, <arjan@linux•intel.com>,
<meego-dev@meego•com>, "Wang, Yong Y" <yong.y.wang@intel•com>,
<gregkh@suse•de>, <netdev@vger•kernel.org>,
<socketcan-core@lists•berlios.de>,
"Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel•com>,
"Morinaga" <morinaga526@dsn•okisemi.com>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Fri, 20 Aug 2010 17:37:41 +0900 [thread overview]
Message-ID: <000401cb4042$f5ea66f0$66f8800a@maildom.okisemi.com> (raw)
In-Reply-To: 4C6E35D5.2080500@grandegger.com
Hi Wolfgang,
Thank you for your comment.
We don't use kfifo infrastructure but brush up with current framework.
Thanks, Ohtake(OKISEMI)
----- Original Message -----
From: "Wolfgang Grandegger" <wg@grandegger•com>
To: "Masayuki Ohtake" <masa-korg@dsn•okisemi.com>
Cc: "Wang, Qi" <qi.wang@intel•com>; <arjan@linux•intel.com>; <meego-dev@meego•com>; "Wang, Yong Y"
<yong.y.wang@intel•com>; <gregkh@suse•de>; <netdev@vger•kernel.org>; <socketcan-core@lists•berlios.de>; "Khor, Andrew
Chih Howe" <andrew.chih.howe.khor@intel•com>; "Morinaga" <morinaga526@dsn•okisemi.com>
Sent: Friday, August 20, 2010 4:59 PM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35
> Hi Ohtake,
>
> On 08/20/2010 08:01 AM, Masayuki Ohtake wrote:
> > Hi Wolfgang,
> >
> >>>>>> 2. Why don't you use kernel existing kfifo infrastructure? ([2]).
> >>>>> Just take a look at kfifo.h. This structure has been changed. I remembered
> >>>> there was a spin_lock from kfifo previously. Currently it's been removed, good.
> >>>>> OKI-sans, would you please take a look at ./include/linux/kfifo.h, and try to
> >>>> use this structure and APIs?
> >>>>
> >>>> As I see it, the code related to that fifo is not used (== dead code)?
> >>> I'm not familiar with kfifo structure, and I didn't like it because there need a spin_lock to use it.
> >
> > We are about to study kfifo infra structure.
> > I have a question.
> >
> > It seems all CAN drivers accepted by upstream don't use kfifo infrastructure, right ?
>
> Right!
>
> > (I couldn't see message with "grep kfifo * in drivers/net/can")
> >
> > If yes, why should we use the kfifo ?
> > If no, please show me the kfifo reference driver
>
> Sorry, nobody (of the socketcan core developers) said that kfifo should
> be used. We believe, that an additional queuing of CAN messages is *not*
> needed at all. Just eliminate the related code and follow more closely
> the existing mainline drivers.
>
> Wolfgang.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-08-20 8:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 0:25 [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 Masayuki Ohtak
[not found] ` <4C61EDE5.4030505-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-08-11 10:37 ` Daniel Baluta
2010-08-12 1:42 ` Wang, Qi
2010-08-12 2:04 ` Greg KH
2010-08-12 2:13 ` Wang, Qi
[not found] ` <20100812020414.GD14121-l3A5Bk7waGM@public.gmane.org>
2010-08-12 6:25 ` Oliver Hartkopp
2010-08-12 6:29 ` Wang, Qi
2010-08-12 2:39 ` Masayuki Ohtake
[not found] ` <D5AB6E638E5A3E4B8F4406B113A5A19A28EA26EB-QQHDSDV1ERZpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-08-12 5:17 ` Daniel Baluta
2010-08-12 9:03 ` Wolfgang Grandegger
2010-08-13 0:23 ` Wang, Qi
[not found] ` <D5AB6E638E5A3E4B8F4406B113A5A19A28EA2AB1-QQHDSDV1ERZpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-08-13 6:11 ` Daniel Baluta
2010-08-13 10:58 ` Wolfgang Grandegger
2010-08-20 6:01 ` Masayuki Ohtake
[not found] ` <000f01cb402d$34b675b0$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-08-20 7:59 ` Wolfgang Grandegger
2010-08-20 8:37 ` Masayuki Ohtake [this message]
2010-08-11 12:31 ` Wolfgang Grandegger
[not found] ` <D5AB6E638E5A3E4B8F4406B113A5A19A28EA26CC@shsmsx501.ccr.corp.intel.com>
[not found] ` <4C63B6C9.5050804@grandegger.com>
[not found] ` <D5AB6E638E5A3E4B8F4406B113A5A19A28EA29DF@shsmsx501.ccr.corp.intel.com>
2010-09-01 7:45 ` Masayuki Ohtake
[not found] ` <000501cb49a9$9cd4bf00$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-09-01 17:04 ` out-of-order tx objects - was " Oliver Hartkopp
2010-09-01 18:51 ` Wolfgang Grandegger
2010-09-02 3:19 ` Masayuki Ohtake
[not found] ` <001301cb4a4d$b4c4ba80$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-09-02 6:32 ` Wolfgang Grandegger
2010-08-11 13:04 ` Marc Kleine-Budde
2010-09-13 12:07 ` Masayuki Ohtake
[not found] ` <005f01cb533e$5c21d530$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-09-13 12:29 ` Marc Kleine-Budde
2010-09-14 0:46 ` Masayuki Ohtake
2010-09-14 7:08 ` Marc Kleine-Budde
[not found] ` <003a01cb53a6$4ca724d0$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-09-15 7:42 ` Wolfgang Grandegger
[not found] ` <4C9078D3.50300-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-09-15 9:42 ` Oliver Hartkopp
2010-09-15 10:55 ` Wolfgang Grandegger
2010-09-15 12:04 ` Marc Kleine-Budde
2010-09-15 12:11 ` Wolfgang Grandegger
2010-09-13 15:22 ` Greg KH
2010-09-14 8:48 ` Masayuki Ohtake
[not found] ` <00ca01cb53e9$a50c1930$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>
2010-09-14 13:10 ` Greg KH
2010-09-15 1:21 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401cb4042$f5ea66f0$66f8800a@maildom.okisemi.com' \
--to=masa-korg@dsn$(echo .)okisemi.com \
--cc=andrew.chih.howe.khor@intel$(echo .)com \
--cc=arjan@linux$(echo .)intel.com \
--cc=gregkh@suse$(echo .)de \
--cc=meego-dev@meego$(echo .)com \
--cc=morinaga526@dsn$(echo .)okisemi.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=qi.wang@intel$(echo .)com \
--cc=socketcan-core@lists$(echo .)berlios.de \
--cc=wg@grandegger$(echo .)com \
--cc=yong.y.wang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox