From: "Sriranjani P" <sriranjani.p@samsung•com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro•org>,
<davem@davemloft•net>, <edumazet@google•com>, <kuba@kernel•org>,
<pabeni@redhat•com>, <robh+dt@kernel•org>,
<krzysztof.kozlowski+dt@linaro•org>, <conor+dt@kernel•org>,
<richardcochran@gmail•com>, <alexandre.torgue@foss•st.com>,
<joabreu@synopsys•com>, <mcoquelin.stm32@gmail•com>,
<alim.akhtar@samsung•com>, <linux-fsd@tesla•com>,
<pankaj.dubey@samsung•com>, <swathi.ks@samsung•com>,
<ravi.patel@samsung•com>
Cc: <netdev@vger•kernel.org>, <devicetree@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
<linux-samsung-soc@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>,
"'Jayati Sahu'" <jayati.sahu@samsung•com>
Subject: RE: [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC
Date: Wed, 16 Aug 2023 11:56:57 +0530 [thread overview]
Message-ID: <001101d9d00a$aab8d2f0$002a78d0$@samsung.com> (raw)
In-Reply-To: <ae1107f7-d48e-d89f-4de9-f8d01abcc3e2@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro•org]
> Sent: 15 August 2023 01:12
> To: Sriranjani P <sriranjani.p@samsung•com>; davem@davemloft•net;
> edumazet@google•com; kuba@kernel•org; pabeni@redhat•com;
> robh+dt@kernel•org; krzysztof.kozlowski+dt@linaro•org;
> conor+dt@kernel•org; richardcochran@gmail•com;
> alexandre.torgue@foss•st.com; joabreu@synopsys•com;
> mcoquelin.stm32@gmail•com; alim.akhtar@samsung•com; linux-
> fsd@tesla•com; pankaj.dubey@samsung•com; swathi.ks@samsung•com;
> ravi.patel@samsung•com
> Cc: netdev@vger•kernel.org; devicetree@vger•kernel.org; linux-
> kernel@vger•kernel.org; linux-samsung-soc@vger•kernel.org; linux-arm-
> kernel@lists•infradead.org; Jayati Sahu <jayati.sahu@samsung•com>
> Subject: Re: [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC
> Block of FSD SoC
>
> On 14/08/2023 21:41, Krzysztof Kozlowski wrote:
> > On 14/08/2023 13:25, Sriranjani P wrote:
> >> The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP,
> >> one in
> >> FSYS0 block and other in PERIC block.
> >>
> >> Adds device tree node for Ethernet in PERIC Block and enables the
> >> same for FSD platform.
> >>
> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
> >> Signed-off-by: Jayati Sahu <jayati.sahu@samsung•com>
> >> Signed-off-by: Swathi K S <swathi.ks@samsung•com>
> >> Signed-off-by: Sriranjani P <sriranjani.p@samsung•com>
> >> ---
> >> arch/arm64/boot/dts/tesla/fsd-evb.dts | 9 ++++
> >> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56
> ++++++++++++++++++++++
> >> arch/arm64/boot/dts/tesla/fsd.dtsi | 29 +++++++++++
> >> 3 files changed, 94 insertions(+)
> >
> > Looks duplicated.
>
> Ah, not, it's another block.
>
> My question whether this was tested remains...
I understand your concern. It was tested but just before posting I addressed one of earlier review comment of compatible and I missed to reflect it in all the patches. I will take care.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-08-16 6:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230814112600epcas5p49fe29a3ef85e2b0158f5ee3426652fc8@epcas5p4.samsung.com>
2023-08-14 11:25 ` [PATCH v3 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
2023-08-14 11:25 ` [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Sriranjani P
2023-08-14 13:33 ` Rob Herring
2023-08-16 5:36 ` Sriranjani P
2023-08-16 5:40 ` Krzysztof Kozlowski
2023-08-17 14:54 ` Rob Herring
2023-08-14 19:39 ` Krzysztof Kozlowski
2023-08-16 5:58 ` Sriranjani P
2023-08-16 6:18 ` Krzysztof Kozlowski
2024-06-06 9:14 ` Swathi K S
2023-08-14 20:39 ` Andrew Lunn
2024-06-06 9:14 ` Swathi K S
2024-06-06 13:25 ` Andrew Lunn
2024-07-29 8:47 ` Swathi K S
2023-08-14 11:25 ` [PATCH v3 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Sriranjani P
2023-08-14 19:50 ` Krzysztof Kozlowski
2023-08-16 6:38 ` Sriranjani P
2023-08-18 9:27 ` Krzysztof Kozlowski
2024-06-06 9:14 ` Swathi K S
2024-06-06 12:16 ` Krzysztof Kozlowski
2023-08-14 20:47 ` Andrew Lunn
2024-06-06 9:16 ` Swathi K S
2023-08-14 11:25 ` [PATCH v3 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Sriranjani P
2023-08-14 19:40 ` Krzysztof Kozlowski
2023-08-14 19:56 ` Krzysztof Kozlowski
2023-08-16 6:40 ` Sriranjani P
2023-08-14 20:50 ` Andrew Lunn
2024-06-06 9:14 ` Swathi K S
2024-06-06 13:22 ` Andrew Lunn
2024-07-29 8:49 ` Swathi K S
2023-08-14 20:51 ` Andrew Lunn
2023-08-14 11:25 ` [PATCH v3 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Sriranjani P
2023-08-14 19:41 ` Krzysztof Kozlowski
2023-08-14 19:41 ` Krzysztof Kozlowski
2023-08-16 6:26 ` Sriranjani P [this message]
2023-08-14 20:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101d9d00a$aab8d2f0$002a78d0$@samsung.com' \
--to=sriranjani.p@samsung$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=jayati.sahu@samsung$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsd@tesla$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pankaj.dubey@samsung$(echo .)com \
--cc=ravi.patel@samsung$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=swathi.ks@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox