From: Paul Durrant <xadimgnik@gmail•com>
To: "'Juergen Gross'" <jgross@suse•com>,
<xen-devel@lists•xenproject.org>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Cc: "'Wei Liu'" <wei.liu@kernel•org>,
"'David S. Miller'" <davem@davemloft•net>,
"'Jakub Kicinski'" <kuba@kernel•org>
Subject: RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case
Date: Thu, 11 Feb 2021 14:15:02 -0000 [thread overview]
Message-ID: <001d01d70080$4a5446d0$defcd470$@xen.org> (raw)
In-Reply-To: <20210211101616.13788-5-jgross@suse.com>
> -----Original Message-----
> From: Juergen Gross <jgross@suse•com>
> Sent: 11 February 2021 10:16
> To: xen-devel@lists•xenproject.org; netdev@vger•kernel.org; linux-kernel@vger•kernel.org
> Cc: Juergen Gross <jgross@suse•com>; Wei Liu <wei.liu@kernel•org>; Paul Durrant <paul@xen•org>; David
> S. Miller <davem@davemloft•net>; Jakub Kicinski <kuba@kernel•org>
> Subject: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case
>
> In case of a common event for rx and tx queue the event should be
> regarded to be spurious if no rx and no tx requests are pending.
>
> Unfortunately the condition for testing that is wrong causing to
> decide a event being spurious if no rx OR no tx requests are
> pending.
>
> Fix that plus using local variables for rx/tx pending indicators in
> order to split function calls and if condition.
>
Definitely neater.
> Fixes: 23025393dbeb3b ("xen/netback: use lateeoi irq binding")
> Signed-off-by: Juergen Gross <jgross@suse•com>
Reviewed-by: Paul Durrant <paul@xen•org>
next prev parent reply other threads:[~2021-02-11 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 10:16 [PATCH v2 0/8] xen/events: bug fixes and some diagnostic aids Juergen Gross
2021-02-11 10:16 ` [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case Juergen Gross
2021-02-11 10:53 ` Jan Beulich
2021-02-11 14:15 ` Paul Durrant [this message]
2021-02-11 15:24 ` Wei Liu
2021-02-11 10:16 ` [PATCH v2 5/8] xen/events: link interdomain events to associated xenbus device Juergen Gross
2021-02-11 14:16 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01d70080$4a5446d0$defcd470$@xen.org' \
--to=xadimgnik@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jgross@suse$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul@xen$(echo .)org \
--cc=wei.liu@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox