From: "Jiawen Wu" <jiawenwu@trustnetic•com>
To: "'Andrew Lunn'" <andrew@lunn•ch>
Cc: "'Jakub Kicinski'" <kuba@kernel•org>, <netdev@vger•kernel.org>,
"'Andrew Lunn'" <andrew+netdev@lunn•ch>,
"'David S. Miller'" <davem@davemloft•net>,
"'Eric Dumazet'" <edumazet@google•com>,
"'Paolo Abeni'" <pabeni@redhat•com>,
"'Simon Horman'" <horms@kernel•org>,
"'Russell King \(Oracle\)'" <rmk+kernel@armlinux•org.uk>,
"'Mengyuan Lou'" <mengyuanlou@net-swift•com>
Subject: RE: [PATCH net-next 2/3] net: txgbe: optimize the flow to setup PHY for AML devices
Date: Sat, 11 Oct 2025 09:53:39 +0800 [thread overview]
Message-ID: <002201dc3a51$dd3b1130$97b13390$@trustnetic.com> (raw)
In-Reply-To: <f76ed32e-b007-484c-a228-4b7774a49020@lunn.ch>
On Fri, Oct 10, 2025 9:52 PM, Andrew Lunn wrote:
> On Fri, Oct 10, 2025 at 03:48:57PM +0800, Jiawen Wu wrote:
> > On Tue, Sep 30, 2025 9:40 AM, Jakub Kicinski wrote:
> > > On Sun, 28 Sep 2025 17:39:22 +0800 Jiawen Wu wrote:
> > > > To adapt to new firmware for AML devices, the driver should send the
> > > > "SET_LINK_CMD" to the firmware only once when switching PHY interface
> > > > mode. And the unknown link speed is permitted in the mailbox buffer. The
> > > > firmware will configure the PHY completely when the conditions are met.
> > >
> > > Could you mention what the TXGBE_GPIOBIT_3 does, since you're removing
> > > it all over the place?
> >
> > Okay. It is used for RX signal, which indicate that PHY should be re-configured.
> > Now we remove it from the driver, let the firmware to configure PHY completely.
>
> Does this rely on new firmware? Or has the firmware always configured
> the PHY, and then the driver reconfigures it?
Driver does not configure PHY, it just send the command to firmware when
switching PHY interface. For the old firmware, the PHY is configured only when
"SET_LINK_CMD" is received. But the PHY would not be completely configured if RX
signal lost. So the driver will send the command when TXGBE_GPIOBIT_3 interrupt
occurs. For the new firmware, it will automatically configure PHY when RX signal
arrives.
next prev parent reply other threads:[~2025-10-11 1:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 9:39 [PATCH net-next 0/3] TXGBE feat new AML firmware Jiawen Wu
2025-09-28 9:39 ` [PATCH net-next 1/3] net: txgbe: expend SW-FW mailbox buffer size to identify QSFP module Jiawen Wu
2025-09-29 13:52 ` Simon Horman
2025-10-10 7:42 ` Jiawen Wu
2025-10-10 13:52 ` Andrew Lunn
2025-10-11 1:57 ` Jiawen Wu
2025-10-11 14:20 ` Andrew Lunn
2025-09-28 9:39 ` [PATCH net-next 2/3] net: txgbe: optimize the flow to setup PHY for AML devices Jiawen Wu
2025-09-30 1:39 ` Jakub Kicinski
2025-10-10 7:48 ` Jiawen Wu
2025-10-10 13:51 ` Andrew Lunn
2025-10-11 1:53 ` Jiawen Wu [this message]
2025-09-28 9:39 ` [PATCH net-next 3/3] net: txgbe: rename txgbe_get_phy_link() Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002201dc3a51$dd3b1130$97b13390$@trustnetic.com' \
--to=jiawenwu@trustnetic$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox