Subject: default directive in Kconfig(subject modified)

From: "Ravinandan Arakali" <[email-masked]>
Date: Mon, 8 Aug 2005 17:40:45 -0700

Hi,
Can somebody throw light on the below subject ?
We have S2io configured as a module and 2buff mode is
one of the suboptions under S2io. But a directive such
as "default y" does not seem to enable 2buff mode.

Thanks,
Ravi

-----Original Message-----
From: Ravinandan Arakali [mailto:[email-masked]]
Sent: Friday, July 29, 2005 9:38 AM
To: 'David S. Miller'
Cc: [email-masked]'; [email-masked]';
[email-masked]'; [email-masked]';
[email-masked]'; [email-masked]'
Subject: RE: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

David,
We are trying to use the "default" directive in Kconfig. We tried
using an unconditional directive(just to test it out) such as
"default y" and a conditional one such as "default y if
CONFIG_IA64_SGI_SN2".

But when we run "make menuconfig", it does not seem to pickup any of these
changes from Kconfig.
Any idea what we might be missing ?

Once this is fixed, we'll send out a patch to address comments from
previous 12 patches as well as couple of issues we found in the
meantime.

Thanks,
Ravi

-----Original Message-----
From: David S. Miller [mailto:[email-masked]]
Sent: Tuesday, July 12, 2005 2:04 PM
To: [email-masked]
Cc: [email-masked]; [email-masked];
[email-masked]; [email-masked]; [email-masked];
[email-masked]
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements

From: "Ravinandan Arakali" <[email-masked]>
Subject: RE: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
Date: Tue, 12 Jul 2005 14:00:52 -0700

> The two-buffer mode was added as a configurable option
> to Kconfig file several months ago. Hence the macro
> is CONFIG_2BUFF_MODE.

We're saying that you should choose CONFIG_2BUFF_MODE, when
CONFIG_IA64_SGI_SN2 is set, inside the Kconfig file using the
"default" Kconfig directive.

You should never change the setting of CONFIG_* macros in C source.