From: "Swathi K S" <swathi.ks@samsung•com>
To: "'Krzysztof Kozlowski'" <krzk@kernel•org>
Cc: <netdev@vger•kernel.org>, <devicetree@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
<linux-stm32@st-md-mailman•stormreply.com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-samsung-soc@vger•kernel.org>,
<alexandre.torgue@foss•st.com>, <peppe.cavallaro@st•com>,
<joabreu@synopsys•com>, <rcsekar@samsung•com>,
<ssiddha@tesla•com>, <jayati.sahu@samsung•com>,
<pankaj.dubey@samsung•com>, <ravi.patel@samsung•com>,
<gost.dev@samsung•com>, <robh@kernel•org>, <davem@davemloft•net>,
<edumazet@google•com>, <kuba@kernel•org>, <pabeni@redhat•com>,
<conor+dt@kernel•org>, <richardcochran@gmail•com>,
<mcoquelin.stm32@gmail•com>, <andrew@lunn•ch>,
<alim.akhtar@samsung•com>, <linux-fsd@tesla•com>
Subject: RE: [PATCH v5 1/4] dt-bindings: net: Add FSD EQoS device tree bindings
Date: Wed, 29 Jan 2025 14:48:05 +0530 [thread overview]
Message-ID: <002d01db722e$b6fc4610$24f4d230$@samsung.com> (raw)
In-Reply-To: <1da56c20-c522-428e-81ff-bc2f9ee0f524@kernel.org>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel•org>
> Sent: 28 January 2025 19:45
> To: Swathi K S <swathi.ks@samsung•com>; robh@kernel•org;
> davem@davemloft•net; edumazet@google•com; kuba@kernel•org;
> pabeni@redhat•com; conor+dt@kernel•org; richardcochran@gmail•com;
> mcoquelin.stm32@gmail•com; andrew@lunn•ch; alim.akhtar@samsung•com;
> linux-fsd@tesla•com
> Cc: netdev@vger•kernel.org; devicetree@vger•kernel.org; linux-
> kernel@vger•kernel.org; linux-stm32@st-md-mailman•stormreply.com;
> linux-arm-kernel@lists•infradead.org; linux-samsung-soc@vger•kernel.org;
> alexandre.torgue@foss•st.com; peppe.cavallaro@st•com;
> joabreu@synopsys•com; rcsekar@samsung•com; ssiddha@tesla•com;
> jayati.sahu@samsung•com; pankaj.dubey@samsung•com;
> ravi.patel@samsung•com; gost.dev@samsung•com
> Subject: Re: [PATCH v5 1/4] dt-bindings: net: Add FSD EQoS device tree
> bindings
>
> On 28/01/2025 11:25, Swathi K S wrote:
> > + Tesla ethernet devices based on dwmmac support Gigabit ethernet.
> > +
> > +allOf:
> > + - $ref: snps,dwmac.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: tesla,fsd-ethqos.yaml
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 5
> > + maxItems: 10
>
> Why is this flexible?
>
> Anyway, you need to list and describe the items instead of min/maxItems.
Hi Krzysztof,
There are 2 Ethernet instances where Eth0 has 5 clocks and Eth1 has 10 clocks.
Would it be sufficient to list the clock names?
>
> > +
> > + clock-names:
> > + minItems: 5
> > + maxItems: 10
>
> Same here.
Ack
>
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > + phy-mode:
> > + enum:
> > + - rgmii-id
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - iommus
> > + - phy-mode
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/fsd-clk.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + ethernet_1: ethernet@14300000 {
>
> Please implement last comment from Rob.
>
> > + compatible = "tesla,fsd-ethqos";
> > + reg = <0x0 0x14300000 0x0 0x10000>;
>
> And since there is going to be new version, switch to the preferred
> indentation (4-space). Other option is 2 spaces, but not 8.
Ack, will update it this way in v6.
- Swathi
>
> > +...
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-01-29 11:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250128102707epcas5p154db286b06da942e18ffe315e4767707@epcas5p1.samsung.com>
2025-01-28 10:25 ` [PATCH v5 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2025-01-28 10:25 ` [PATCH v5 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Swathi K S
2025-01-28 14:14 ` Krzysztof Kozlowski
2025-01-29 9:18 ` Swathi K S [this message]
2025-01-30 6:05 ` Swathi K S
2025-01-28 15:40 ` Rob Herring (Arm)
2025-01-28 15:45 ` Rob Herring
2025-01-29 9:20 ` Swathi K S
2025-01-29 12:59 ` Andrew Lunn
2025-01-28 10:25 ` [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2025-01-28 13:48 ` Andrew Lunn
2025-01-29 9:15 ` Swathi K S
2025-01-29 13:01 ` Andrew Lunn
2025-01-28 14:59 ` Russell King (Oracle)
2025-01-29 9:20 ` Swathi K S
2025-01-28 10:25 ` [PATCH v5 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Swathi K S
2025-01-28 10:25 ` [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
2025-01-28 14:18 ` Krzysztof Kozlowski
2025-01-29 9:19 ` Swathi K S
2025-01-29 13:07 ` Andrew Lunn
2025-02-04 8:40 ` [PATCH v5 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002d01db722e$b6fc4610$24f4d230$@samsung.com' \
--to=swathi.ks@samsung$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=gost.dev@samsung$(echo .)com \
--cc=jayati.sahu@samsung$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsd@tesla$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pankaj.dubey@samsung$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=ravi.patel@samsung$(echo .)com \
--cc=rcsekar@samsung$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=ssiddha@tesla$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox