Subject: RE: [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

From: "Swathi K S" <[email-masked]>
Date: Wed, 29 Jan 2025 14:49:14 +0530

> -----Original Message-----
> From: Krzysztof Kozlowski <[email-masked]>
> Sent: 28 January 2025 19:48
> To: Swathi K S <[email-masked]>; [email-masked];
> [email-masked]; [email-masked]; [email-masked];
> [email-masked]; [email-masked]; [email-masked];
> [email-masked]; [email-masked]; [email-masked];
> [email-masked]
> Cc: [email-masked]; [email-masked]; linux-
> [email-masked]; [email-masked];
> [email-masked]; [email-masked];
> [email-masked]; [email-masked];
> [email-masked]; [email-masked]; [email-masked];
> [email-masked]; [email-masked];
> [email-masked]; [email-masked]
> Subject: Re: [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC
> Block of FSD SoC
> 
> On 28/01/2025 11:25, Swathi K S wrote:
> >
> >  &pinctrl_pmu {
> > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > index cc67930ebf78..670f6a852542 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > @@ -1027,6 +1027,33 @@
> >  			phy-mode = "rgmii-id";
> >  			status = "disabled";
> >  		};
> > +
> > +		ethernet_1: ethernet@14300000 {
> 
> Don't add nodes to the end, because that lead to mess we have there.
> Squeeze it somewhere where impact on resorting would be the smallest.

Just to clarify,  inserting the node somewhere in the middle, where it fits alphabetically, would minimize the impact on resorting.
Is my understanding correct?

-Swathi

> Best regards,
> Krzysztof