Subject: RE: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

From: "Esben Haabendal" <[email-masked]>
Date: Tue, 2 Oct 2007 09:10:05 +0200

Hi Scott,

A minor error handling bug

> +	const u32 *data = of_get_property(np, "phy-handle", &len);
> +	if (!data || len != 4)
> +		return -EINVAL;
> +
> +	phynode = of_find_node_by_phandle(*data);
> +	if (!phynode)
> +		return -EINVAL;
> +
> +	mdionode = of_get_parent(phynode);
> +	if (!phynode)

if (!mdionode)

> +		goto out_put_phy;

Best regards,
Esben