From: Byungho An <bh74.an@samsung•com>
To: 'Mark Rutland' <mark.rutland@arm•com>
Cc: 'netdev' <netdev@vger•kernel.org>,
linux-samsung-soc@vger•kernel.org, devicetree@vger•kernel.org,
'David Miller' <davem@davemloft•net>,
'GIRISH K S' <ks.giri@samsung•com>,
'SIVAREDDY KALLAM' <siva.kallam@samsung•com>,
'Vipul Chandrakant' <vipul.pandya@samsung•com>,
'Ilho Lee' <ilho215.lee@samsung•com>
Subject: RE: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe
Date: Fri, 21 Mar 2014 07:24:28 -0700 [thread overview]
Message-ID: <004601cf4511$46c8a970$d459fc50$@samsung.com> (raw)
In-Reply-To: <20140321110423.GN23372@e106331-lin.cambridge.arm.com>
Mark Rutland <mark.rutland@arm•com> wrote:
> On Thu, Mar 20, 2014 at 05:26:06PM +0000, Byungho An wrote:
> > From: Girish K S <ks.giri@samsung•com>
> >
> > Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet
driver.
> >
> > Signed-off-by: Girish K S <ks.giri@samsung•com>
> > Neatening-by: Joe Perches <joe@perches•com>
> > Signed-off-by: Byungho An <bh74.an@samsung•com>
> > ---
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 53 +++++++
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c | 86 +++++++++-
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c | 47 ++++++
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 165
> +++++++++++++++++++-
> > .../net/ethernet/samsung/sxgbe/sxgbe_platform.c | 4 +
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_reg.h | 5 +
> > 6 files changed, 358 insertions(+), 2 deletions(-)
>
> [...]
>
> > diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> > b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> > index e410d84..b23ec57 100644
> > --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> > +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> > @@ -160,6 +160,10 @@ static int sxgbe_platform_probe(struct
> platform_device *pdev)
> > }
> > }
> >
> > + priv->lpi_irq = irq_of_parse_and_map(dev->of_node, loop++);
>
> You can use platform_get_irq(pdev, loop++) here. The interrupts have already
> been parsed elsewhere.
OK.
>
> Cheers,
> Mark.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the
body of
> a message to majordomo@vger•kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-21 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 17:26 [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe Byungho An
2014-03-21 11:04 ` Mark Rutland
2014-03-21 14:24 ` Byungho An [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004601cf4511$46c8a970$d459fc50$@samsung.com' \
--to=bh74.an@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=ilho215.lee@samsung$(echo .)com \
--cc=ks.giri@samsung$(echo .)com \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=siva.kallam@samsung$(echo .)com \
--cc=vipul.pandya@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox