Subject: RE: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

From: Byungho An <[email-masked]>
Date: Mon, 17 Mar 2014 10:38:58 -0700

Stephen Hemminger <[email-masked]> wrote:
> On Sun, 16 Mar 2014 20:53:25 -0700
> Byungho An <[email-masked]> wrote:
> 
> > >
> > > They are used but they always point to the same set of methods.
> > > Those methods could thus be directly called.
> > Yes, those methods can be called directly.
> > But I think it is acceptable for manageability and extension for future.
> 
> That argument is only valid if:
>  1. you have hardware that will use it but it is not ready.
>  2. they will get used in next release (in < 6 mo)
I agree, it is expected that they will be used in 3 ~ 4 mo

> 
> Ths set of indirection has negative cost: it impedes readability, has to
be
> maintained, and hurts performance.
> 
> One of the principles of agile programming is NOT to build infrastructure
until
> it is needed. Otherwise you are likely to build it wrong.