Subject: RE: [PATCH net v2 1/4] net: wangxun: fix the incorrect display of queue number in statistics

From: Jiawen Wu <[email-masked]>
Date: Thu, 9 May 2024 10:39:22 +0800

On Wed, May 1, 2024 10:00 AM, Jakub Kicinski wrote:
> On Mon, 29 Apr 2024 18:25:16 +0800 Jiawen Wu wrote:
> > When using ethtool -S to print hardware statistics, the number of
> > Rx/Tx queues printed is greater than the number of queues actually
> > used.
> 
> The ethtool API fetches the number of stats and the values in an
> unsafe, non-atomic way. If someone increases the number of queues
> while someone else is fetching the stats the memory of the latter
> process will get corrupted. The code is correct as is.

So should we keep the old code, showing stats with fixed maximum
number of queues?