Subject: RE: [PATCH iproute2 rdma: Ignore unknown netlink attributes

From: "Steve Wise" <[email-masked]>
Date: Tue, 3 Apr 2018 08:32:36 -0500

> -----Original Message-----
> From: Leon Romanovsky <[email-masked]>
> Sent: Tuesday, April 3, 2018 2:29 AM
> To: Stephen Hemminger <[email-masked]>
> Cc: Leon Romanovsky <[email-masked]>; netdev
> <[email-masked]>; RDMA mailing list <linux-
> [email-masked]>; David Ahern <[email-masked]>; Steve Wise
> <[email-masked]>
> Subject: [PATCH iproute2 rdma: Ignore unknown netlink attributes
> 
> From: Leon Romanovsky <[email-masked]>
> 
> The check if netlink attributes supplied more than maximum supported
> is to strict and may lead to backward compatibility issues with old
> application with a newer kernel that supports new attribute.
> 
> CC: Steve Wise <[email-masked]>
> Fixes: 74bd75c2b68d ("rdma: Add basic infrastructure for RDMA tool")
> Signed-off-by: Leon Romanovsky <[email-masked]>
> ---
>  rdma/utils.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rdma/utils.c b/rdma/utils.c
> index a2e08e91..5c1e736a 100644
> --- a/rdma/utils.c
> +++ b/rdma/utils.c
> @@ -399,7 +399,8 @@ int rd_attr_cb(const struct nlattr *attr, void *data)
>  	int type;
> 
>  	if (mnl_attr_type_valid(attr, RDMA_NLDEV_ATTR_MAX) < 0)
> -		return MNL_CB_ERROR;
> +		/* We received uknown attribute */
> +		return MNL_CB_OK;
> 
>  	type = mnl_attr_get_type(attr);
> 

Hey Leon,

So the resource parsing functions correctly ignore the unkown attrs and
print everything else?

Looks good.

Reviewed-by: Steve Wise <[email-masked]>