public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: "voncken" <cedric.voncken@acksys•fr>
To: "'Claudiu Manoil'" <claudiu.manoil@freescale•com>
Cc: <netdev@vger•kernel.org>
Subject: RE: Gianfar driver issue
Date: Wed, 12 Dec 2012 09:46:57 +0100	[thread overview]
Message-ID: <029701cdd845$3ed5e280$bc81a780$@acksys.fr> (raw)
In-Reply-To: <50C744CE.7040109@freescale.com>

	Thanks claudiu, 

	I will reformat my patch and resend it.

	Regards.

Cedric Voncken 

-----Message d'origine-----
De : Claudiu Manoil [mailto:claudiu.manoil@freescale•com] 
Envoyé : mardi 11 décembre 2012 15:36
À : Cedric VONCKEN
Cc : netdev@vger•kernel.org
Objet : Re: Gianfar driver issue

On 12/11/2012 11:59 AM, Cedric VONCKEN wrote:
> 	Hi all,
>
> 	I think he have an issue in Gianfar driver.
>
> 	When the Netdev tx queue timeout occurred, the function
> gfar_timeout(..) is called. This function calls indirectly the
> gfar_init_mac(..) function.
>
> 	In this function, the rctrl register is set to a default value.
>
> 	If the Promiscuous is enable on the net dev ( flag IFF_PROMISC is 
> set), the gfar_init_function does not reactivate it.
>
> 	The Promiscuous mode is used for example when the netdev is bridged.
> 	
> 	I apply this patch to fix it.
>
> 	--- a/drivers/net/ethernet/freescale/gianfar.c.	2012-06-01
> 09:16:13.000000000 +0200
> 	+++ b/drivers/net/ethernet/freescale/gianfar.c	2012-12-11
> 10:38:23.000000000 +0100
> 	@@ -356,6 +356,11 @@
>   	/* Configure the coalescing support */
>   	gfar_configure_coalescing(priv, 0xFF, 0xFF);
>
> +	if (ndev->flags & IFF_PROMISC) {
> +		/* Set RCTRL to PROM */
> +		rctrl |= RCTRL_PROM;
> +	}
> +
>   	if (priv->rx_filer_enable) {
>   		rctrl |= RCTRL_FILREN;
>   		/* Program the RIR0 reg with the required distribution */

Hello,

I don't see any issue with this code change, and there are other drivers too
reconfiguring the promiscuous mode upon tx timeout.
A valid (formatted) patch needs to be sent however.

Thanks,
Claudiu

     prev parent reply	other threads:[~2012-12-12  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11  9:59 Gianfar driver issue Cedric VONCKEN
2012-12-11 14:35 ` Claudiu Manoil
2012-12-12  8:46   ` voncken [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='029701cdd845$3ed5e280$bc81a780$@acksys.fr' \
    --to=cedric.voncken@acksys$(echo .)fr \
    --cc=claudiu.manoil@freescale$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox