From: "Jiawen Wu" <jiawenwu@trustnetic•com>
To: "'Vadim Fedorenko'" <vadim.fedorenko@linux•dev>,
<andrew+netdev@lunn•ch>, <davem@davemloft•net>,
<edumazet@google•com>, <kuba@kernel•org>, <pabeni@redhat•com>,
<richardcochran@gmail•com>, <linux@armlinux•org.uk>,
<horms@kernel•org>, <jacob.e.keller@intel•com>,
<netdev@vger•kernel.org>
Cc: <mengyuanlou@net-swift•com>
Subject: RE: [PATCH net-next v2 1/4] net: wangxun: Add support for PTP clock
Date: Tue, 7 Jan 2025 10:01:03 +0800 [thread overview]
Message-ID: <034f01db60a8$01da7d70$058f7850$@trustnetic.com> (raw)
In-Reply-To: <836cb511-2fef-479e-8743-662cb3884b2c@linux.dev>
> > +/**
> > + * wx_ptp_create_clock
> > + * @wx: the private board structure
> > + *
> > + * Returns 0 on success, negative value on failure
> > + *
> > + * This function performs setup of the user entry point function table and
> > + * initalizes the PTP clock device used by userspace to access the clock-like
> > + * features of the PTP core. It will be called by wx_ptp_init, and may
> > + * re-use a previously initialized clock (such as during a suspend/resume
> > + * cycle).
> > + */
> > +static long wx_ptp_create_clock(struct wx *wx)
> > +{
> > + struct net_device *netdev = wx->netdev;
> > + long err;
> > +
> > + /* do nothing if we already have a clock device */
> > + if (!IS_ERR_OR_NULL(wx->ptp_clock))
> > + return 0;
> > +
> > + snprintf(wx->ptp_caps.name, sizeof(wx->ptp_caps.name),
> > + "%s", netdev->name);
> > + wx->ptp_caps.owner = THIS_MODULE;
> > + wx->ptp_caps.n_alarm = 0;
> > + wx->ptp_caps.n_ext_ts = 0;
> > + wx->ptp_caps.n_per_out = 0;
> > + wx->ptp_caps.pps = 0;
> > + wx->ptp_caps.adjfine = wx_ptp_adjfine;
> > + wx->ptp_caps.adjtime = wx_ptp_adjtime;
> > + wx->ptp_caps.gettimex64 = wx_ptp_gettimex64;
> > + wx->ptp_caps.settime64 = wx_ptp_settime64;
> > + wx->ptp_caps.do_aux_work = wx_ptp_do_aux_work;
>
> wx_ptp_do_aux_work is not defined in this patch, it appears in patch 3
> only. did you compile test your code patch by patch?
I think I may have created some confusion between the coding and testing
machines...
Thanks for your careful review.
next prev parent reply other threads:[~2025-01-07 2:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:45 [PATCH net-next v2 0/4] Support PTP clock for Wangxun NICs Jiawen Wu
2025-01-06 8:45 ` [PATCH net-next v2 1/4] net: wangxun: Add support for PTP clock Jiawen Wu
2025-01-06 10:35 ` Vadim Fedorenko
2025-01-07 2:01 ` Jiawen Wu [this message]
2025-01-06 8:45 ` [PATCH net-next v2 2/4] net: wangxun: Implement get_ts_info Jiawen Wu
2025-01-06 10:28 ` Vadim Fedorenko
2025-01-06 8:45 ` [PATCH net-next v2 3/4] net: wangxun: Implement do_aux_work of ptp_clock_info Jiawen Wu
2025-01-06 10:36 ` Vadim Fedorenko
2025-01-06 15:16 ` Richard Cochran
2025-01-06 21:35 ` Keller, Jacob E
2025-01-07 5:59 ` Jiawen Wu
2025-01-08 0:33 ` Keller, Jacob E
2025-01-08 2:52 ` Jiawen Wu
2025-01-08 6:28 ` Jiawen Wu
2025-01-08 18:09 ` Keller, Jacob E
2025-01-07 1:50 ` Jiawen Wu
2025-01-06 8:45 ` [PATCH net-next v2 4/4] net: ngbe: Add support for 1PPS and TOD Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='034f01db60a8$01da7d70$058f7850$@trustnetic.com' \
--to=jiawenwu@trustnetic$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox