From: Martin KaFai Lau <martin.lau@linux•dev>
To: Jason Xing <kerneljasonxing@gmail•com>,
Willem de Bruijn <willemdebruijn.kernel@gmail•com>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, dsahern@kernel•org, willemb@google•com,
ast@kernel•org, daniel@iogearbox•net, andrii@kernel•org,
eddyz87@gmail•com, song@kernel•org, yonghong.song@linux•dev,
john.fastabend@gmail•com, kpsingh@kernel•org, sdf@fomichev•me,
haoluo@google•com, jolsa@kernel•org, shuah@kernel•org,
ykolal@fb•com, bpf@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH bpf-next v13 00/12] net-timestamp: bpf extension to equip applications transparently
Date: Thu, 20 Feb 2025 15:02:41 -0800 [thread overview]
Message-ID: <04bfac2e-e28d-45eb-a715-59ac4b58aca8@linux.dev> (raw)
In-Reply-To: <67b74b0ca099e_261ab62945f@willemb.c.googlers.com.notmuch>
On 2/20/25 7:32 AM, Willem de Bruijn wrote:
> Jason Xing wrote:
>> "Timestamping is key to debugging network stack latency. With
>> SO_TIMESTAMPING, bugs that are otherwise incorrectly assumed to be
>> network issues can be attributed to the kernel." This is extracted
>> from the talk "SO_TIMESTAMPING: Powering Fleetwide RPC Monitoring"
>> addressed by Willem de Bruijn at netdevconf 0x17).
>>
>> There are a few areas that need optimization with the consideration of
>> easier use and less performance impact, which I highlighted and mainly
>> discussed at netconf 2024 with Willem de Bruijn and John Fastabend:
>> uAPI compatibility, extra system call overhead, and the need for
>> application modification. I initially managed to solve these issues
>> by writing a kernel module that hooks various key functions. However,
>> this approach is not suitable for the next kernel release. Therefore,
>> a BPF extension was proposed. During recent period, Martin KaFai Lau
>> provides invaluable suggestions about BPF along the way. Many thanks
>> here!
>>
>> This series adds the BPF networking timestamping infrastructure through
>> reusing most of the tx timestamping callback that is currently enabled
>> by the SO_TIMESTAMPING.. This series also adds TX timestamping support
>> for TCP. The RX timestamping and UDP support will be added in the future.
Thanks for working on this BPF feature. Applied.
> This series addresses all my feedback.
>
> The timestamping patches all have my Reviewed-by.
Thanks to Willem and other reviewers for their input in this long thread across
many revisions.
next prev parent reply other threads:[~2025-02-20 23:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 7:29 [PATCH bpf-next v13 00/12] net-timestamp: bpf extension to equip applications transparently Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 01/12] bpf: add networking timestamping support to bpf_get/setsockopt() Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 02/12] bpf: prepare the sock_ops ctx and call bpf prog for TX timestamping Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 03/12] bpf: prevent unsafe access to the sock fields in the BPF timestamping callback Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 04/12] bpf: disable unsafe helpers in TX timestamping callbacks Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 05/12] net-timestamp: prepare for isolating two modes of SO_TIMESTAMPING Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 06/12] bpf: add BPF_SOCK_OPS_TSTAMP_SCHED_CB callback Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 07/12] bpf: add BPF_SOCK_OPS_TSTAMP_SND_SW_CB callback Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 08/12] bpf: add BPF_SOCK_OPS_TSTAMP_SND_HW_CB callback Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 09/12] bpf: add BPF_SOCK_OPS_TSTAMP_ACK_CB callback Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 10/12] bpf: add BPF_SOCK_OPS_TSTAMP_SENDMSG_CB callback Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 11/12] bpf: support selective sampling for bpf timestamping Jason Xing
2025-02-20 7:29 ` [PATCH bpf-next v13 12/12] selftests/bpf: add simple bpf tests in the tx path for timestamping feature Jason Xing
2025-02-20 15:32 ` [PATCH bpf-next v13 00/12] net-timestamp: bpf extension to equip applications transparently Willem de Bruijn
2025-02-20 23:02 ` Martin KaFai Lau [this message]
2025-02-20 23:17 ` Jason Xing
2025-02-20 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04bfac2e-e28d-45eb-a715-59ac4b58aca8@linux.dev \
--to=martin.lau@linux$(echo .)dev \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=eddyz87@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kerneljasonxing@gmail$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=shuah@kernel$(echo .)org \
--cc=song@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=ykolal@fb$(echo .)com \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox