Subject: RE: [PATCH net-next v1 2/7] net: ngbe: improve the reset flow

From: Jiawen Wu <[email-masked]>
Date: Wed, 4 Feb 2026 10:20:00 +0800

On Tue, Feb 3, 2026 9:56 PM, Andrew Lunn wrote:
> >  static void ngbe_reset(struct wx *wx)
> >  {
> > +	int err;
> > +
> > +	err = ngbe_reset_hw(wx);
> > +	if (err != 0)
> 
> The != 0 is a bit odd. It looks like rest of the driver uses if (err)
> 
> > +		wx_err(wx, "Hardware Error: %d\n", err);
> 
> I also wounder if this should be fatal? Should ngbe_reset() be made an
> int function so the error code can be returned?

The error returned by ngbe_reset_hw() indicates that there is a hardware
issue, and the recovery process will be handled in another work queue.
We hope that the driver can continue to complete the remaining software
reset.