From: "Jiawen Wu" <jiawenwu@trustnetic•com>
To: "'Russell King \(Oracle\)'" <linux@armlinux•org.uk>
Cc: <davem@davemloft•net>, <edumazet@google•com>, <kuba@kernel•org>,
<pabeni@redhat•com>, <andrew@lunn•ch>, <netdev@vger•kernel.org>,
<mengyuanlou@net-swift•com>
Subject: RE: [PATCH net-next v3 1/7] net: ngbe: implement phylink to handle PHY device
Date: Fri, 8 Dec 2023 15:12:46 +0800 [thread overview]
Message-ID: <06f201da29a5$f1f04910$d5d0db30$@trustnetic.com> (raw)
In-Reply-To: <ZXBjwWjd1Jv8916K@shell.armlinux.org.uk>
On Wednesday, December 6, 2023 8:06 PM, Russell King (Oracle) wrote:
> On Wed, Dec 06, 2023 at 05:53:49PM +0800, Jiawen Wu wrote:
> > Add phylink support for Wangxun 1Gb Ethernet controller.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic•com>
> > ---
> > drivers/net/ethernet/wangxun/libwx/wx_type.h | 8 ++
> > drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 20 ++-
> > drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c | 126 +++++++++++-------
> > drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.h | 2 +-
> > 4 files changed, 93 insertions(+), 63 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> > index 165e82de772e..9225aaf029f8 100644
> > --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h
> > +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> > @@ -8,6 +8,7 @@
> > #include <linux/netdevice.h>
> > #include <linux/if_vlan.h>
> > #include <net/ip.h>
> > +#include <linux/phylink.h>
>
> Nit: would be better to keep linux/ includes together (and in
> alphabetical order to prevent conflicts.)
>
> > diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> > index 8db804543e66..c61f4b9d79fa 100644
> > --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> > +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> > @@ -9,6 +9,7 @@
> > #include <linux/etherdevice.h>
> > #include <net/ip.h>
> > #include <linux/phy.h>
> > +#include <linux/phylink.h>
> > #include <linux/if_vlan.h>
> >
> > #include "../libwx/wx_type.h"
>
> As wx_type.h includes linux/phylink.h, which is now fundamental for the
> definition of one of the structures in wx_type.h, the include of
> linux/phylink.h seems unnecessary here.
Should I remove the include of linux/phylink.h that have been added in other .c files?
next prev parent reply other threads:[~2023-12-08 7:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 9:53 [PATCH net-next v3 0/7] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 1/7] net: ngbe: implement phylink to handle PHY device Jiawen Wu
2023-12-06 12:06 ` Russell King (Oracle)
2023-12-08 7:12 ` Jiawen Wu [this message]
2023-12-06 9:53 ` [PATCH net-next v3 2/7] net: wangxun: unified phylink implementation in libwx Jiawen Wu
2023-12-06 12:15 ` Russell King (Oracle)
2023-12-06 9:53 ` [PATCH net-next v3 3/7] net: wangxun: add flow control support Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 4/7] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-12-06 17:37 ` Jakub Kicinski
2023-12-06 9:53 ` [PATCH net-next v3 5/7] net: wangxun: add coalesce options support Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 6/7] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-12-06 17:35 ` Jakub Kicinski
2023-12-06 9:53 ` [PATCH net-next v3 7/7] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='06f201da29a5$f1f04910$d5d0db30$@trustnetic.com' \
--to=jiawenwu@trustnetic$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox