From: Tony Nguyen <anthony.l.nguyen@intel•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: <davem@davemloft•net>, <pabeni@redhat•com>, <edumazet@google•com>,
"Michal Jaron" <michalx.jaron@intel•com>,
<netdev@vger•kernel.org>, Kamil Maziarz <kamil.maziarz@intel•com>,
Gurucharan <gurucharanx.g@intel•com>
Subject: Re: [PATCH net 2/3] i40e: Fix not setting xps_cpus after reset
Date: Wed, 28 Sep 2022 11:26:33 -0700 [thread overview]
Message-ID: <084792cf-07b9-8342-31cf-1fea93ce1940@intel.com> (raw)
In-Reply-To: <20220927182933.30d691d2@kernel.org>
On 9/27/2022 6:29 PM, Jakub Kicinski wrote:
> On Mon, 26 Sep 2022 13:32:13 -0700 Tony Nguyen wrote:
>> During tx rings configuration default XPS queue config is set and
>> __I40E_TX_XPS_INIT_DONE is locked. XPS CPUs maps are cleared in
>> every reset by netdev_set_num_tc() call regardless it was set by
>> user or driver. If reset with reinit occurs __I40E_TX_XPS_INIT_DONE
>> flag is removed and XPS mapping is set to default again but after
>> reset without reinit this flag is still set and XPS CPUs to queues
>> mapping stays cleared.
>>
>> Add code to preserve xps_cpus mapping as cpumask for every queue
>> and restore those mapping at the end of reset.
>
> Not sure this is a fix, are there other drivers in the tree which do
> this? In the drivers I work with IRQ mapping and XPS are just seemingly
> randomly reset on reconfiguration changes. User space needs to rerun its
> affinitization script after all changes it makes.
In the interest of the other patches, hopefully, making this kernel, I'm
going to drop this from the pull request while it's being discussed.
Thanks,
Tony
next prev parent reply other threads:[~2022-09-28 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 20:32 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2022-09-26 (i40e) Tony Nguyen
2022-09-26 20:32 ` [PATCH net 1/3] i40e: Fix ethtool rx-flow-hash setting for X722 Tony Nguyen
2022-09-26 20:32 ` [PATCH net 2/3] i40e: Fix not setting xps_cpus after reset Tony Nguyen
2022-09-28 1:29 ` Jakub Kicinski
2022-09-28 13:32 ` Jaron, MichalX
2022-09-28 14:11 ` Jakub Kicinski
2022-09-29 11:58 ` Jaron, MichalX
2022-10-06 22:28 ` Tony Nguyen
2022-10-07 0:11 ` Jakub Kicinski
2022-09-28 18:26 ` Tony Nguyen [this message]
2022-09-26 20:32 ` [PATCH net 3/3] i40e: Fix DMA mappings leak Tony Nguyen
2022-09-27 2:58 ` Rout, ChandanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=084792cf-07b9-8342-31cf-1fea93ce1940@intel.com \
--to=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gurucharanx.g@intel$(echo .)com \
--cc=kamil.maziarz@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michalx.jaron@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox