From: Mathieu Desnoyers <mathieu.desnoyers@efficios•com>
To: Alexei Starovoitov <ast@fb•com>
Cc: rostedt <rostedt@goodmis•org>,
"David S. Miller" <davem@davemloft•net>,
Daniel Borkmann <daniel@iogearbox•net>,
Linus Torvalds <torvalds@linux-foundation•org>,
Peter Zijlstra <peterz@infradead•org>,
netdev <netdev@vger•kernel.org>, kernel-team <kernel-team@fb•com>,
linux-api <linux-api@vger•kernel.org>
Subject: Re: [PATCH v6 bpf-next 07/11] tracepoint: introduce kernel_tracepoint_find_by_name
Date: Tue, 27 Mar 2018 12:09:23 -0400 (EDT) [thread overview]
Message-ID: <1095960167.1226.1522166963714.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <8600dbae-389d-dd01-f003-44f1af7dcf0a@fb.com>
----- On Mar 27, 2018, at 11:53 AM, Alexei Starovoitov ast@fb•com wrote:
> On 3/27/18 7:42 AM, Steven Rostedt wrote:
>> On Tue, 27 Mar 2018 10:18:24 -0400 (EDT)
>> Mathieu Desnoyers <mathieu.desnoyers@efficios•com> wrote:
>>
>>> ----- On Mar 27, 2018, at 10:07 AM, rostedt rostedt@goodmis•org wrote:
>>>
>>>> On Mon, 26 Mar 2018 19:47:02 -0700
>>>> Alexei Starovoitov <ast@fb•com> wrote:
>>>>
>>>>> From: Alexei Starovoitov <ast@kernel•org>
>>>>>
>>>>> introduce kernel_tracepoint_find_by_name() helper to let bpf core
>>>>> find tracepoint by name and later attach bpf probe to a tracepoint
>>>>>
>>>>> Signed-off-by: Alexei Starovoitov <ast@kernel•org>
>>>>
>>>> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis•org>
>>>
>>> Steven showed preference for tracepoint_kernel_find_by_name() at some
>>> point (starting with a tracepoint_ prefix). I'm find with either of
>>> the names.
>>
>> Yeah, I do prefer tracepoint_kernel_find_by_name() to stay consistent
>> with the other tracepoint functions. But we have
>> "for_each_kernel_tracepoint()" and not "for_each_tracepoint_kernel()",
>> thus we need to pick being consistent with one or the other. One answer
>> is to use tracpoint_kernel_find_by_name() and rename the for_each to
>> for_each_tracpoint_kernel().
>
> yep. that's exactly the reason I picked kernel_tracepoint_find_by_name()
> to match for_each_kernel_tracepoint() naming.
>
> I can certainly send a follow up patch to rename both to
> *tracepoint_kernel* and then you can nack it because it breaks lttng :)
If Steven prefers changing the name of for_each_kernel_tracepoint() to
for_each_tracepoint_kernel(), I'll adapt LTTng accordingly. I don't
mind either way, as long as the change is justified.
Thanks,
Mathieu
> but let's do it in a separate thread.
>
> Daniel,
> do you mind adding { } as Steven requested while applying or
> you want me to resubmit the whole thing?
>
> Thanks!
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2018-03-27 16:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 2:46 [PATCH v6 bpf-next 00/11] bpf, tracing: introduce bpf raw tracepoints Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 01/11] treewide: remove large struct-pass-by-value from tracepoint arguments Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 02/11] net/mediatek: disambiguate mt76 vs mt7601u trace events Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 03/11] net/mac802154: disambiguate mac80215 vs mac802154 " Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 04/11] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 05/11] macro: introduce COUNT_ARGS() macro Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 06/11] tracepoint: compute num_args at build time Alexei Starovoitov
2018-03-27 15:15 ` Steven Rostedt
2018-03-27 2:47 ` [PATCH v6 bpf-next 07/11] tracepoint: introduce kernel_tracepoint_find_by_name Alexei Starovoitov
2018-03-27 14:07 ` Steven Rostedt
2018-03-27 14:18 ` Mathieu Desnoyers
2018-03-27 14:42 ` Steven Rostedt
2018-03-27 15:53 ` Alexei Starovoitov
2018-03-27 16:09 ` Mathieu Desnoyers [this message]
2018-03-27 16:36 ` Daniel Borkmann
2018-03-27 2:47 ` [PATCH v6 bpf-next 08/11] bpf: introduce BPF_RAW_TRACEPOINT Alexei Starovoitov
2018-03-27 17:02 ` Steven Rostedt
2018-03-27 17:11 ` Steven Rostedt
2018-03-27 18:58 ` Steven Rostedt
2018-03-27 21:04 ` Steven Rostedt
2018-03-27 22:48 ` Alexei Starovoitov
2018-03-27 23:13 ` Mathieu Desnoyers
2018-03-28 0:00 ` Alexei Starovoitov
2018-03-28 0:44 ` Mathieu Desnoyers
2018-03-28 0:51 ` Alexei Starovoitov
2018-03-28 14:06 ` Steven Rostedt
2018-03-27 18:45 ` Alexei Starovoitov
2018-03-27 19:00 ` Steven Rostedt
2018-03-27 19:07 ` Steven Rostedt
2018-03-27 19:10 ` Steven Rostedt
2018-03-27 19:10 ` Mathieu Desnoyers
2018-03-27 2:47 ` [PATCH v6 bpf-next 09/11] libbpf: add bpf_raw_tracepoint_open helper Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 10/11] samples/bpf: raw tracepoint test Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 11/11] selftests/bpf: test for bpf_get_stackid() from raw tracepoints Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095960167.1226.1522166963714.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios$(echo .)com \
--cc=ast@fb$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=kernel-team@fb$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox