Subject: Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources

From: Pavel Roskin <proski-mXXj517/[email-masked]>
Date: Fri, 07 Apr 2006 18:21:57 -0400

On Fri, 2006-04-07 at 23:36 +0200, Francois Romieu wrote:

> > @@ -208,8 +205,8 @@ static int orinoco_pci_init_one(struct p
> >  	priv = netdev_priv(dev);
> >  	card = priv->card;
> >  	card->pci_ioaddr = pci_ioaddr;
> > -	dev->mem_start = pci_iorange;
> > -	dev->mem_end = pci_iorange + pci_iolen - 1;
> > +	dev->mem_start = pci_resource_start(pdev, 0);
> > +	dev->mem_end = dev->mem_start + pci_resource_len(pdev, 0) - 1;
> 
> Is there a reason why dev->mem_{start/end} should not be removed ?

Is there a reason why it should?  Is it going to be obsolete?

-- 
Regards,
Pavel Roskin

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642