Subject: Re: [PATCH 4/6] tg3: Add reset_phy parameter to chip reset functions

From: "Michael Chan" <[email-masked]>
Date: Mon, 01 May 2006 08:19:40 -0700

On Sat, 2006-04-29 at 18:59 -0700, David S. Miller wrote:
> From: "Michael Chan" <[email-masked]>
> Date: Fri, 28 Apr 2006 16:36:08 -0700
> 
> > Add a reset_phy parameter to tg3_reset_hw() and tg3_init_hw(). With
> > the full chip reset during MAC address change, the automatic PHY reset
> > during chip reset will cause a link down and bonding will not work
> > properly as a result. With this reset_phy parameter, we can do a chip
> > reset without link down when changing MAC address or MTU.
> > 
> > Signed-off-by: Gary Zambrano <[email-masked]>
> > Signed-off-by: Michael Chan <[email-masked]>
> 
> Applied.
> 
> Doesn't the signalling interface between the MAC and the
> PHY get reset during a chip reset and couldn't that cause
> problems if we bypass the PHY reset?

The PHY reset is needed if the PHY was previously put into low power
mode. In the cases where we reset the chip due to MTU or MAC address
changes, the power settings are not changed and therefore PHY reset is
not needed.