Subject: Re: netif_tx_disable and lockless TX

From: "Michael Chan" <[email-masked]>
Date: Wed, 31 May 2006 14:20:29 -0700

On Tue, 2006-05-30 at 22:11 -0700, David Miller wrote:
> From: Herbert Xu <[email-masked]>
> Date: Wed, 31 May 2006 14:58:11 +1000
> 
> > Yes, TG3 does not disable IRQs when taking its TX lock.  So do you see
> > any problems with replacing the TG3 TX lock using xmit_lock?
> 
> I don't see any.
> 
David, So do we want to fix this issue as proposed by Herbert to replace
tx_lock with xmit_lock? It seems quite straightforward to do. For this
change to work, netpoll also needs to be fixed up a bit to check for
LLTX before getting the xmit_lock.