Subject: Re: [NET]: Added GSO header verification

From: "Michael Chan" <[email-masked]>
Date: Tue, 27 Jun 2006 13:46:35 -0700

On Tue, 2006-06-27 at 22:07 +1000, Herbert Xu wrote:

> [NET]: Added GSO header verification
>
> @@ -2166,10 +2166,14 @@ struct sk_buff *tcp_tso_segment(struct s
>         if (!pskb_may_pull(skb, thlen))
>                 goto out;
>  
> +       segs = NULL;
> +       if (skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))
> +               goto out;
> +

This logic doesn't look right to me.  Perhaps it's backwards and should
be:

if (!skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))