Subject: Re: sky2: hw checksum failures

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 05 Sep 2006 13:42:38 +1000

On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote:
> Unneeded byte swap was occurring.
> 
> --- linux-2.6.orig/drivers/net/sky2.c
> +++ linux-2.6/drivers/net/sky2.c
> @@ -2001,7 +2001,7 @@ static int sky2_status_intr(struct sky2_
>  		case OP_RXCHKS:
>  			skb = sky2->rx_ring[sky2->rx_next].skb;
>  			skb->ip_summed = CHECKSUM_HW;
> -			skb->csum = le16_to_cpu(status);
> +			skb->csum = status;
>  			break;
>  
>  		case OP_TXINDEXLE:

I've removed it in my paches (have you seen the other patches I sent for
this driver ?), though I'm pre-swapping status and lenght now before the
switch/case so there might still be an issue there. I'll have a look.

Thanks,
Ben.