Subject: Re: d80211: RFC: divide by zero when hw->maxssi not set

From: Dan Williams <[email-masked]>
Date: Sun, 19 Nov 2006 18:55:23 -0500

On Fri, 2006-11-17 at 15:51 -0800, David Kimdon wrote:
> Hi,
> 
> commit 448bf25bc9e3d70a211fdf235426472089371c43 added
> ieee80211_get_wireless_stats in net/d80211/ieee80211_ioctl.c.  At
> present we get a divide by zero (oops) if the low level driver does
> not set the new hw->maxssi field.  Perhaps:
> 
> - reject registration of devices which do not set maxssi
> - do not attempt to report link quality for drivers which do not 
>   set maxssi
> - other ideas? 

#1 could be too draconian, but has the benefit of making driver writers
put _something_ there.  Either way, it's pretty obvious to anyone that
the driver is broken for quality reporting.  But at least #1 forces the
issue to making quality somewhat work.

Dan

> -David
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html