public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom•com>
To: davem@davemloft•net, netdev@vger•kernel.org
Subject: [PATCH 3/11][TG3]: Clear GPIO mask before storing.
Date: Fri, 04 May 2007 17:52:38 -0700	[thread overview]
Message-ID: <1178326358.4859.19.camel@dell> (raw)

[TG3]: Clear GPIO mask before storing.

The GPIO settings may change during reset and so the stored values in
tp->grc_local_ctrl should be cleared first.

Signed-off-by: Gary Zambrano <zambrano@broadcom•com>
Signed-off-by: Michael Chan <mchan@broadcom•com>

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index c01bd86..00027a1 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -6454,6 +6454,7 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy)
 		if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5755)
 			gpio_mask |= GRC_LCLCTRL_GPIO_UART_SEL;
 
+		tp->grc_local_ctrl &= ~gpio_mask;
 		tp->grc_local_ctrl |= tr32(GRC_LOCAL_CTRL) & gpio_mask;
 
 		/* GPIO1 must be driven high for eeprom write protect */



             reply	other threads:[~2007-05-05  0:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-05  0:52 Michael Chan [this message]
2007-05-05 18:51 ` [PATCH 3/11][TG3]: Clear GPIO mask before storing David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178326358.4859.19.camel@dell \
    --to=mchan@broadcom$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox