Subject: Re: [LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable

From: jamal <[email-masked]>
Date: Mon, 14 May 2007 08:41:38 -0400

On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote:

> Two final suggestions, sorry for not mentioning this earlier.

np

> > +			printk(KERN_DEBUG
> > +			       "Dead loop on netdevice %s, fix it urgently!\n",
> > +			       dev->name);
> 
> > +	if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit()))
> > +		printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret, q->q.qlen);
> 
> 
> For both of these KERN_WARNING or above 

I will make them KERN_WARNING ..

> seems to make sense so
> the messages don't end up in some debug log. Please also fix
> whitespace 

What whitespace issue?

> and line length for the second printk if you're
> going to change this :)

I will fix the length of the second one.

Thanks Patrick.

cheers,
jamal