Subject: Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

From: Joe Perches <[email-masked]>
Date: Mon, 11 Jun 2007 14:54:40 -0700

On Mon, 2007-06-11 at 14:37 -0700, Auke Kok wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 3a70f55..d185f41 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -540,6 +540,8 @@ struct net_device
>  	struct device		dev;
>  	/* space for optional statistics and wireless sysfs groups */
>  	struct attribute_group  *sysfs_groups[3];
> +
> +	int			msg_enable;
>  };
>  #define to_net_dev(d) container_of(d, struct net_device, dev)
>  

msg_enable is more frequently defined in drivers/net as u32 not int.

egrep -r -w --include=*.[ch] "u32[[:space:]]+msg_enable" drivers/net | wc -l
egrep -r -w --include=*.[ch] "int[[:space:]]+msg_enable" drivers/net | wc -l

29 to 5

cheers, Joe