Subject: Re: [lvs-devel] [patch 2/2] ipvs: Syncrhonise Closing of Connections

From: Rumen Bogdanovski <[email-masked]>
Date: Fri, 02 Nov 2007 11:47:20 +0200

I should have been very tired to miss this one when I looked at the
patch... 
I looked again in the version I have tested. For some
reason/net/ipv4/ipvs/ip_vs_sync.c is not patched at all, this is what I
have missed.

Rumen

On Fri, 2007-11-02 at 09:53 +0900, Simon Horman wrote:
> On Fri, Nov 02, 2007 at 01:36:07AM +0200, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Thu, 1 Nov 2007, Simon Horman wrote:
> > 
> > > --- net-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c	2007-11-01 18:17:55.000000000 +0900
> > > +++ net-2.6/net/ipv4/ipvs/ip_vs_sync.c	2007-11-01 18:20:30.000000000 +0900
> > > @@ -332,7 +332,7 @@ static void ip_vs_process_message(const 
> > >  					    s->daddr, s->dport,
> > >  					    flags, dest);
> > >  			if (dest)
> > 
> > 	Is that correct? Sorry, I was flooded with different versions
> > of this patch and I'm not sure if it is the final one.
> > 
> > > -				atomic_dec(&dest->refcnt);
> > > +				ip_vs_dest_get(dest);
> > >  			if (!cp) {
> > >  				IP_VS_ERR("ip_vs_conn_new failed\n");
> > >  				return;
> 
> The ip_vs_dest_get() call shouldn't be there.
> I'll double check the rest of the patch.
>