Subject: Re: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller

From: Joe Perches <[email-masked]>
Date: Tue, 27 Nov 2007 22:47:54 -0800

On Tue, 2007-11-27 at 22:09 -0800, Stephen Hemminger wrote:
> ERROR: Macros with multiple statements should be enclosed in a do - while loop
> #21846: FILE: drivers/net/sfc/net_driver.h:1096:
> +	for (_channel = &_efx->channel[0];				\
> +	     _channel < &_efx->channel[EFX_MAX_CHANNELS];		\
> +	     _channel++)						\

This should probably be a WARNING in checkpatch.
Any list_for_each style macro fails this test.