Subject: Re: [1/4] DST: Distributed storage documentation.

From: Kay Sievers <[email-masked]>
Date: Mon, 10 Dec 2007 20:56:49 +0100

On Mon, 2007-12-10 at 22:51 +0300, Evgeniy Polyakov wrote:
> On Mon, Dec 10, 2007 at 08:44:55PM +0100, Kay Sievers ([email-masked]) wrote:
> > > > > Actually not - I have to set reference counter to something other than 1
> > > > > or +/- 1, and thus will have to call kref_get() in a loop, which is a
> > > > > very ugly step. Is there kref_set() or somethinglike that? At least not
> > > > > in 2.6.22 what I'm using for now.
> > > > 
> > > > Yeah, a loop would look pretty ugly. How about just adding kref_set(),
> > > > if you need it.
> > > 
> > > Well, then it distributed storage will not be able to build as
> > > standalone module, and kref_set() itself will not be accepted as a single 
> > > patch, since there are no in-kernel users :)
> > > It is easily doable though.
> > 
> > Most rules have exceptions. :) Send a patch, so we can see how it looks
> > like.
> 
> It looks really non-trivial :)

Yeah, it does. :)
We miss an EXPORT_SYMBOL(), right?

Kay