From: Edward Cree <ecree.xilinx@gmail•com>
To: "Russell King (Oracle)" <linux@armlinux•org.uk>, edward.cree@amd•com
Cc: linux-net-drivers@amd•com, davem@davemloft•net, kuba@kernel•org,
edumazet@google•com, pabeni@redhat•com, netdev@vger•kernel.org,
habetsm.xilinx@gmail•com, sudheer.mogilappagari@intel•com,
jdamato@fastly•com, andrew@lunn•ch, mw@semihalf•com,
sgoutham@marvell•com, gakula@marvell•com, sbhatta@marvell•com,
hkelam@marvell•com, saeedm@nvidia•com, leon@kernel•org
Subject: Re: [RFC PATCH v3 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts
Date: Wed, 13 Sep 2023 12:24:21 +0100 [thread overview]
Message-ID: <11bdf0aa-25aa-05b4-e40b-8d108cdc9424@gmail.com> (raw)
In-Reply-To: <ZQCUeTrMpmxhlW9C@shell.armlinux.org.uk>
On 12/09/2023 17:40, Russell King (Oracle) wrote:
> On Tue, Sep 12, 2023 at 03:21:41PM +0100, edward.cree@amd•com wrote:
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index f12767466427..2acb4d8cd4c7 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -10054,6 +10054,7 @@ int register_netdevice(struct net_device *dev)
>> idr_init_base(&dev->ethtool->rss_ctx, 1);
>>
>> spin_lock_init(&dev->addr_list_lock);
>> + mutex_init(&dev->ethtool->rss_lock);
>
> Is there a reason to split this from the idr (eventually xarray)
> initialisation above? Surely initialisations for a feature (rss)
> should all be grouped together?
No real reason; I just thought "put locks together" made sense, but
I guess "put rss stuff together" makes more, can change it.
-e
next prev parent reply other threads:[~2023-09-13 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 14:21 [RFC PATCH v3 net-next 0/7] ethtool: track custom RSS contexts in the core edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 1/7] net: move ethtool-related netdev state into its own struct edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 2/7] net: ethtool: attach an IDR of custom RSS contexts to a netdevice edward.cree
2023-09-12 16:36 ` Russell King (Oracle)
2023-09-13 11:22 ` Edward Cree
2023-09-13 15:10 ` Matthew Wilcox
2023-09-12 14:21 ` [RFC PATCH v3 net-next 3/7] net: ethtool: record custom RSS contexts in the IDR edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 4/7] net: ethtool: let the core choose RSS context IDs edward.cree
2023-09-19 11:10 ` Martin Habets
2023-09-19 14:36 ` Edward Cree
2023-09-20 9:05 ` Martin Habets
2023-09-12 14:21 ` [RFC PATCH v3 net-next 5/7] net: ethtool: add an extack parameter to new rxfh_context APIs edward.cree
2023-09-12 14:21 ` [RFC PATCH v3 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts edward.cree
2023-09-12 16:40 ` Russell King (Oracle)
2023-09-13 11:24 ` Edward Cree [this message]
2023-09-12 14:21 ` [RFC PATCH v3 net-next 7/7] sfc: use new rxfh_context API edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11bdf0aa-25aa-05b4-e40b-8d108cdc9424@gmail.com \
--to=ecree.xilinx@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=hkelam@marvell$(echo .)com \
--cc=jdamato@fastly$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=sudheer.mogilappagari@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox