Subject: Re: [PATCH] tg3: ethtool phys_id default (rev2)

From: "Michael Chan" <[email-masked]>
Date: Fri, 22 Feb 2008 11:16:42 -0800

On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote:
> When asked to blink LEDs the tg3 driver behaves when using:
> 	ethtool -p ethX
> The default value for data is zero, and other drivers interpret this
> as blink forever (or at least a really long time).  The tg3 driver
> interprets this as blink once.  All drivers should have the same
> behaviour.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>

Acked-by: Michael Chan <[email-masked]>

We should do this across the board for bnx2, bnx2x, and niu as well.