Subject: Re: drivers/net/tokenring/smctr.c: logical-bitwise or confusion?

From: Joe Perches <[email-masked]>
Date: Sun, 09 Mar 2008 18:27:27 -0700

On Mon, 2008-03-10 at 02:16 +0100, Roel Kluin wrote:
> diff --git a/drivers/net/tokenring/smctr.c b/drivers/net/tokenring/smctr.c
> index 8909050..8ae5837 100644
> --- a/drivers/net/tokenring/smctr.c
> +++ b/drivers/net/tokenring/smctr.c
> @@ -3413,7 +3413,7 @@ static int smctr_make_tx_status_code(struct net_device *dev,
>          tsv->svi = TRANSMIT_STATUS_CODE;
>          tsv->svl = S_TRANSMIT_STATUS_CODE;
>  
> -        tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) || IBM_PASS_SOURCE_ADDR);
> +        tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) | IBM_PASS_SOURCE_ADDR);
>  
>          /* Stripped frame status of Transmitted Frame */
>          tsv->svv[1] = tx_fstatus & 0xff;

This has been posted a few times over the last 6 months.

for instance:
http://www.ussg.iu.edu/hypermail/linux/kernel/0710.1/0887.html

Somebody please apply it.