Subject: Re: [PATCH take2][NET_SCHED] cls_u32: refcounting fix for u32_delete()

From: jamal <[email-masked]>
Date: Fri, 11 Apr 2008 09:55:27 -0400

On Fri, 2008-11-04 at 13:48 +0000, Jarek Poplawski wrote:
> On Fri, Apr 11, 2008 at 03:22:51PM +0200, Patrick McHardy wrote:
> ...
> > I'd suggest to behave similar to qdiscs when trying to
> > removing classes that are still referenced, return -EBUSY.
> 
> Of course you are right!
> 
> Jarek P.
> 
> -------------------> (take 2)
> 
> [NET_SCHED] cls_u32: refcounting fix for u32_delete()
> 
> Deleting of nonroot hnodes mostly doesn't work in u32_delete():
> refcnt == 1 is expected, but such hnodes' refcnts are initialized
> with 0 and charged only with "link" nodes. Now they'll start with
> 1 like usual. Thanks to Patrick McHardy for an improving suggestion.
> 
> 
> Signed-off-by: Jarek Poplawski <[email-masked]>
> Cc: Jamal Hadi Salim <[email-masked]>

Thanks as always Jarek.

Acked-by: Jamal Hadi Salim <[email-masked]>

cheers,
jamal