Subject: Re: [PATCH net-next 3/6] [BNX2]: Remove the rx_offset field from the bnx2 structure.

From: "Michael Chan" <[email-masked]>
Date: Fri, 16 May 2008 15:07:09 -0700

On Fri, 2008-05-16 at 21:29 +0100, Ben Hutchings wrote:
> > +#define BNX2_RX_OFFSET               sizeof(struct l2_fhdr) + 2
> 
> The definition needs parentheses around it.  You would get away this
> except for this one place where BNX2_RX_OFFSET is subtracted.

Good point.  The bug would cause the jumbo threshold to be off by 2.  
It would not make much difference in this particular case.

Thanks for spotting this and I'll generate a new patch.