From: "Denis V. Lunev" <den@openvz•org>
To: Paul Moore <paul.moore@hp•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next? 1/1] netlabel: return msg overflow error from netlbl_cipsov4_list faster
Date: Fri, 11 Jul 2008 16:13:12 +0400 [thread overview]
Message-ID: <1215778392.7001.25.camel@iris.sw.ru> (raw)
In-Reply-To: <200807110701.05377.paul.moore@hp.com>
On Fri, 2008-07-11 at 07:01 -0400, Paul Moore wrote:
> On Friday 11 July 2008 6:45:49 am Denis V. Lunev wrote:
> > Currently, we are trying to place the information from the kernel to
> > 1, 2, 3 and 4 pages sequentially. These pages are allocated via slab.
> > Though, from the slab point of view steps 3 and 4 are equivalent on
> > most architectures. So, lets skip 3 pages attempt.
> >
> > By the way, should we switch from .doit to .dumpit interface here?
> > The amount of data seems quite big for me.
> >
> > Signed-off-by: Denis V. Lunev <den@openvz•org>
>
> I'll add my ack to this patch because your logic sounds reasonable and
> I'm glad to have more eyes on the code :)
cool :)
> However, I not a big fan of converting this from a .doit to a .dumpit
> interface because this would cause userspace breakage. We could
> potentially do both for backwards compatibility but I have no idea if
> it is possible to have both interfaces available at the same time. One
> thing to keep in mind before diving into your favorite editor is that
> I've yet to hear of there being a problem with this NetLabel command
> and the .doit interface, we may want to hold off to see if it becomes
> an issue.
>
> Acked-by: Paul Moore <paul.moore@hp•com>
for the dumpip interface. 2-order page is a real pain on the heavy
loaded systems. Yes, the allocation will not fail, but it can take a
significant amount of time to perform the allocation.
I understand your logic with keeping this interface, but such allocation
can take > 1 sec for sure.
next prev parent reply other threads:[~2008-07-11 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 10:45 [PATCH net-next? 1/1] netlabel: return msg overflow error from netlbl_cipsov4_list faster Denis V. Lunev
2008-07-11 11:01 ` Paul Moore
2008-07-11 12:13 ` Denis V. Lunev [this message]
2008-07-11 13:32 ` Paul Moore
2008-07-15 5:29 ` David Miller
2008-07-15 12:47 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215778392.7001.25.camel@iris.sw.ru \
--to=den@openvz$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.moore@hp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox