From: Jesper Dangaard Brouer <jdb@comx•dk>
To: Patrick McHardy <kaber@trash•net>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: Bisect'ed BUG in VLAN promisc mode (6c78dcbd47)
Date: Fri, 26 Sep 2008 21:34:30 +0200 [thread overview]
Message-ID: <1222457670.2381.8.camel@localhost.localdomain> (raw)
In-Reply-To: <48DD37E3.9090706@trash.net>
On Fri, 2008-09-26 at 21:28 +0200, Patrick McHardy wrote:
> Patrick McHardy wrote:
> > Jesper Dangaard Brouer wrote:
> >> On Fri, 2008-09-26 at 18:14 +0200, Patrick McHardy wrote:
> >>> Jesper Dangaard Brouer wrote:
> >>>> Hi Patrick,
> >>>>
> >>>> Bisected me down to one of you changes
> >>>> commit 6c78dcbd47a68a
> >>>> [VLAN]: Fix promiscous/allmulti synchronization races
> >>>>
> >>>> Description:
> >>>> ------------
> >>>> All other VLAN interfaces stop working, if a vlan is taken down
> >>>> (ifconfig eth1.1025 down) _while_ there is a tcpdump running on that
> >>>> interface.
> >>>>
> >>>> The problem is a result of promisc mode being removed on the
> >>>> real-device (eth1), when the vlan interface is taken down. This
> >>>> should not happen as other vlan devices exists that still need
> >>>> promisc mode on the real-device (eth1).
> >>> I'm pretty sure we fixed this already in commit 0ed21b32.
> >>
> >> I think that I have tested including this commit. The first thing I did
> >> was to test with latest DaveM net-2.6 git tree.
> >
> > Let me see if I can reproduce it ...
>
> Actually - one question: you're saying you're using different MAC
> addresses on the VLAN devices, so I guess thats why you're expecting
> the underlying device to still be in promiscous mode after you set
> eth1.1025 down. For devices that support multiple unicast addresses
> in hardware, we don't put the device in promiscous mode anymore.
> So the question is: is something actually not working, or did you
> just notice that the real device is no longer in promiscous mode?
It stopped working! In the test setup I do have a machine connected to
eth1.1013, where I have a ping running, that stop working...
I use the tg3 driver for both netcards. Don't know if it supports it?
--
Med venlig hilsen / Best regards
Jesper Brouer
ComX Networks A/S
Linux Network developer
Cand. Scient Datalog / MSc.
Author of http://adsl-optimizer.dk
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2008-09-26 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 14:00 Bisect'ed BUG in VLAN promisc mode (6c78dcbd47) Jesper Dangaard Brouer
2008-09-26 16:14 ` Patrick McHardy
2008-09-26 19:22 ` Jesper Dangaard Brouer
2008-09-26 19:24 ` Patrick McHardy
2008-09-26 19:28 ` Patrick McHardy
2008-09-26 19:34 ` Jesper Dangaard Brouer [this message]
2008-09-26 19:41 ` Patrick McHardy
2008-09-26 20:10 ` Patrick McHardy
2008-10-02 16:38 ` Jesper Dangaard Brouer
2008-10-06 11:03 ` Patrick McHardy
2008-10-07 11:03 ` Jesper Dangaard Brouer
2008-10-07 11:10 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222457670.2381.8.camel@localhost.localdomain \
--to=jdb@comx$(echo .)dk \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox