Subject: Re: [PATCH 2/2] net: define feature flags for FCoE offloads

From: Ben Hutchings <[email-masked]>
Date: Mon, 06 Oct 2008 23:37:22 +0100

On Mon, 2008-10-06 at 15:09 -0700, Yi Zou wrote:
> From: Chris Leech <[email-masked]>
> 
> Signed-off-by: Chris Leech <[email-masked]>
> Signed-off-by: Yi Zou <[email-masked]>
> ---
> 
>  include/linux/netdevice.h |    3 +++
>  include/linux/skbuff.h    |    2 ++
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 9cfd20b..ef65927 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -522,6 +522,8 @@ struct net_device
>  #define NETIF_F_NETNS_LOCAL	8192	/* Does not change network namespaces */
>  #define NETIF_F_LRO		32768	/* large receive offload */
>  
> +#define NETIF_F_FCOE_CRC	(1 << 24) /* FCoE CRC32 */
> +
>  	/* Segmentation offload features */
>  #define NETIF_F_GSO_SHIFT	16
>  #define NETIF_F_GSO_MASK	0xffff0000
[...]

NETIF_F_FCOE_CRC shouldn't be included in NETIF_F_GSO_MASK.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.