Subject: Re: [PATCH] virtio_net: don't set NETIF_F_FRAGLIST

From: Mark McLoughlin <[email-masked]>
Date: Thu, 06 Nov 2008 10:10:29 +0000

On Thu, 2008-11-06 at 08:53 +1100, Rusty Russell wrote:
> On Wednesday 05 November 2008 23:34:46 Mark McLoughlin wrote:
> > We don't handle skb_shared_info->frag_list, so we shouldn't
> > be setting the NETIF_F_FRAGLIST flag.
> 
> We don't?
> 
> skb_to_sgvec() should handle it OK, is there some subtlety I'm missing?

Good grief ... yes, sorry.

Same is true for the tun patch, but I wonder ... could a fraglist skb
exceed 64k? i.e. we need to know the max possible size of a packet
before reading it from the tap.

Cheers,
Mark.