Subject: Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings

From: Ben Hutchings <[email-masked]>
Date: Thu, 06 Nov 2008 12:33:15 +0000

On Thu, 2008-11-06 at 00:39 -0500, Jeff Garzik wrote:
> [email-masked] wrote:
> > From: Andrew Morton <[email-masked]>
> > 
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_write_limit':
> > drivers/net/sfc/falcon.c:1679: warning: comparison of distinct pointer types lacks a cast
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_read':
> > drivers/net/sfc/falcon.c:1720: warning: comparison of distinct pointer types lacks a cast
> > 
> > Driver seems rather confused about types.  Try to help it.
[...]
> I would prefer min_t()...

Andrew has dropped this patch as it is no longer applicable.  I do have
a patch to clean up the length types which I'll submit later.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.