Subject: Re: [PATCH 7/8] ethtool: Add GGRO and SGRO ops

From: Ben Hutchings <[email-masked]>
Date: Fri, 12 Dec 2008 20:11:17 +0000

On Fri, 2008-12-12 at 16:31 +1100, Herbert Xu wrote:
> ethtool: Add GGRO and SGRO ops
> 
> This patch adds the ethtool ops to enable and disable GRO.  It also
> makes GRO depend on RX checksum offload much the same as how TSO
> depends on SG support.
[...]

Why don't you add NETIF_F_GRO to the flags handled by get_flags() and
set_flags()?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.