Subject: Re: [NET-NEXT PATCH 1/2] igb: defeature tx head writeback

From: Joe Perches <[email-masked]>
Date: Wed, 24 Dec 2008 15:18:29 -0800

On Wed, 2008-12-24 at 14:31 -0800, Jeff Kirsher wrote:
> diff --git a/drivers/net/igb/igb.h b/drivers/net/igb/igb.h
> index 2121b8b..c906325 100644
> --- a/drivers/net/igb/igb.h
> +++ b/drivers/net/igb/igb.h
[]
> @@ -127,7 +125,8 @@ struct igb_buffer {
>  		/* TX */
>  		struct {
>  			unsigned long time_stamp;
> -			u32 length;
> +			u16 length;
> +			u16 next_to_watch;
>  		};
>  		/* RX */
>  		struct {

struct igb_buffer {
	struct sk_buff *skb;
	dma_addr_t dma;
	union {
		/* TX */
		struct {
			unsigned long time_stamp;
			u32 length;
		};
		/* RX */
		struct {
			struct page *page;
			u64 page_dma;
			unsigned int page_offset;
		};
	};
};

anonymous unions with anonymous structs?
That's not used very often in kernel source.
Should it be used here?