Subject: Re: [net-next PATCH 4/6] igb: misc cleanup to combine one if statement and set last_rx

From: Ben Hutchings <[email-masked]>
Date: Fri, 13 Feb 2009 13:23:23 +0000

On Thu, 2009-02-12 at 20:18 -0800, Jeff Kirsher wrote:
> From: Alexander Duyck <[email-masked]>
> 
> This patch combines a pair of if statements into one and adds a line to
> update netdev->last_rx.
[...]

You shouldn't need to update last_rx any more:

commit 6cf3f41e6c08bca6641a695449791c38a25f35ff
Author: Jay Vosburgh <[email-masked]>
Date:   Mon Nov 3 18:16:50 2008 -0800

    bonding, net: Move last_rx update into bonding recv logic
    
        The only user of the net_device->last_rx field is bonding.
    This patch adds a conditional update of last_rx to the bonding special
    logic in skb_bond_should_drop, causing last_rx to only be updated when
    the ARP monitor is running.
    
        This frees network device drivers from the necessity of
    updating last_rx, which can have cache line thrash issues.
    
    Signed-off-by: Jay Vosburgh <[email-masked]>
    Signed-off-by: David S. Miller <[email-masked]>

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.