Subject: Re: SiS 191 failure with MTU > 1496

From: Pascal Terjan <[email-masked]>
Date: Tue, 02 Jun 2009 16:14:44 +0200

Le mardi 02 juin 2009 à 13:50 +0200, Pascal Terjan a écrit :
> Le samedi 30 mai 2009 à 00:30 +0200, Francois Romieu a écrit :
> > Pascal Terjan <[email-masked]> :
> > [...]
> > > Oh and even
> > > http://bugzilla.kernel.org/show_bug.cgi?id=10694
> > 
> > Yes, it sucks.
> > 
> > > Should I add some info there ?
> > 
> > Not yet but could you retry with RX_BUF_SIZE set to 1544,
> > 1528 and 1520 ?
> > 
> 
> 1544, 1528 and 1520 fail the same way

By the way there is some strange code:

tp->rx_buf_sz = (mtu > RX_BUF_SIZE) ? mtu + ETH_HLEN + 8 : RX_BUF_SIZE;

Isn't there a (different from the one I'm interested in :) ) bug when
1500 < mtu <= RX_BUF_SIZE

Shouldn't the test be (mtu > ETH_DATA_LEN) ?