Subject: Re: [RFC][PATCH][v4] net/ethtool: Add support for the ethtool feature to flash firmware image from a specified file.

From: Ben Hutchings <[email-masked]>
Date: Thu, 20 Aug 2009 18:24:32 +0100

On Thu, 2009-08-20 at 22:46 +0530, Ajit Khaparde wrote:
[...]
> @@ -489,6 +501,7 @@ struct ethtool_ops {
>  	int	(*get_stats_count)(struct net_device *);/* use get_sset_count */
>  	int	(*get_rxnfc)(struct net_device *, struct ethtool_rxnfc *, void *);
>  	int	(*set_rxnfc)(struct net_device *, struct ethtool_rxnfc *);
> +	int     (*flash_device)(struct net_device *, u8 *);
[...]

The second parameter type should be struct ethtool_flash * not u8 *.
The compiler warning should make this easy to spot...

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.