From: Daniel Walker <dwalker@fifo99•com>
To: kxie@chelsio•com
Cc: davem@davemloft•net, swise@opengridcomputing•com,
divy@chelsio•com, rakesh@chelsio•com, michaelc@cs•wisc.edu,
James.Bottomley@HansenPartnership•com,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH v3 net-next-2.6] cxgb3: Added private MAC address and provisioning packet handler for iSCSI
Date: Sat, 26 Sep 2009 12:22:39 -0700 [thread overview]
Message-ID: <1253992959.20648.434.camel@desktop> (raw)
In-Reply-To: <200909261903.n8QJ3D2b000882@localhost.localdomain>
On Sat, 2009-09-26 at 12:03 -0700, kxie@chelsio•com wrote:
> enum { /* rx_offload flags */
> T3_RX_CSUM = 1 << 0,
> T3_LRO = 1 << 1,
> };
>
> +enum {
> + LAN_MAC_IDX = 0,
> + SAN_MAC_IDX,
> +
> + MAX_MAC_IDX
> +};
Why not name the enum and use it in the function declarations? I see
there are some other unnamed enums in there so you are following the
style in the file already.. However, naming the enum and using it allows
the input values to be known instead of just saying "int n", so I think
that's a better method..
Daniel
prev parent reply other threads:[~2009-09-26 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 19:03 [PATCH v3 net-next-2.6] cxgb3: Added private MAC address and provisioning packet handler for iSCSI kxie
2009-09-26 19:22 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253992959.20648.434.camel@desktop \
--to=dwalker@fifo99$(echo .)com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=divy@chelsio$(echo .)com \
--cc=kxie@chelsio$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michaelc@cs$(echo .)wisc.edu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rakesh@chelsio$(echo .)com \
--cc=swise@opengridcomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox