From: Ben Hutchings <bhutchings@solarflare•com>
To: Vincent Sanders <vince@simtec•co.uk>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] Fix IXP 2000 network driver building.
Date: Mon, 12 Oct 2009 13:10:59 +0100 [thread overview]
Message-ID: <1255349459.2931.7.camel@achroite> (raw)
In-Reply-To: <1255276546-31903-1-git-send-email-vince@simtec.co.uk>
On Sun, 2009-10-11 at 16:55 +0100, Vincent Sanders wrote:
> The IXP 2000 network driver was failing to build as it has its own
> statistics gathering which was not compatible with the recent network
> device operations changes. This patch fixes the driver in the obvious
> way and has been compile tested. I have been unable to get the ixp2000
> maintainer to comment or test this fix.
[...]
> diff --git a/drivers/net/ixp2000/ixpdev.c
> b/drivers/net/ixp2000/ixpdev.c
> index 1272434..79cb6fa 100644
> --- a/drivers/net/ixp2000/ixpdev.c
> +++ b/drivers/net/ixp2000/ixpdev.c
> @@ -21,6 +21,7 @@
> #include "ixp2400_tx.ucode"
> #include "ixpdev_priv.h"
> #include "ixpdev.h"
> +#include "pm3386.h"
>
> #define DRV_MODULE_VERSION "0.2"
>
> @@ -271,6 +272,15 @@ static int ixpdev_close(struct net_device *dev)
> return 0;
> }
>
> +static struct net_device_stats *ixpdev_get_stats(struct net_device
> *dev)
> +{
> + struct ixpdev_priv *ip = netdev_priv(dev);
> +
> + pm3386_get_stats(ip->channel, &(ip->stats));
> +
> + return &(ip->stats);
> +}
> +
[...]
Is there any reason you can't use dev->stats instead of this private
field?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-10-12 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 15:55 [PATCH] Fix IXP 2000 network driver building Vincent Sanders
2009-10-12 12:10 ` Ben Hutchings [this message]
2009-10-12 12:45 ` Vincent Sanders
-- strict thread matches above, loose matches on Subject: below --
2009-10-12 19:46 Vincent Sanders
2009-10-13 7:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255349459.2931.7.camel@achroite \
--to=bhutchings@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vince@simtec$(echo .)co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox